From: Keir Fraser <keir.xen@gmail.com>
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] x86: fix i8259A_resume()
Date: Mon, 14 May 2012 16:33:02 +0100 [thread overview]
Message-ID: <CBD6E43E.331A2%keir.xen@gmail.com> (raw)
In-Reply-To: <4FB10CAC0200007800083700@nat28.tlf.novell.com>
On 14/05/2012 12:46, "Jan Beulich" <JBeulich@suse.com> wrote:
> On systems that have an IO-APIC, we generally run the PIC in AEOI
> mode, yet i8259A_resume() so far failed to put it back into that mode.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Keir Fraser <keir@xen.org>
> --- a/xen/arch/x86/i8259.c
> +++ b/xen/arch/x86/i8259.c
> @@ -314,7 +314,7 @@ static void save_ELCR(char *trigger)
>
> int i8259A_resume(void)
> {
> - init_8259A(0);
> + init_8259A(i8259A_irq_type.ack == disable_8259A_irq);
> restore_ELCR(irq_trigger);
> return 0;
> }
>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
prev parent reply other threads:[~2012-05-14 15:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 11:46 [PATCH] x86: fix i8259A_resume() Jan Beulich
2012-05-14 15:33 ` Keir Fraser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CBD6E43E.331A2%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).