* [PATCH] x86: fix i8259A_resume()
@ 2012-05-14 11:46 Jan Beulich
2012-05-14 15:33 ` Keir Fraser
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2012-05-14 11:46 UTC (permalink / raw)
To: xen-devel
On systems that have an IO-APIC, we generally run the PIC in AEOI
mode, yet i8259A_resume() so far failed to put it back into that mode.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/i8259.c
+++ b/xen/arch/x86/i8259.c
@@ -314,7 +314,7 @@ static void save_ELCR(char *trigger)
int i8259A_resume(void)
{
- init_8259A(0);
+ init_8259A(i8259A_irq_type.ack == disable_8259A_irq);
restore_ELCR(irq_trigger);
return 0;
}
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] x86: fix i8259A_resume()
2012-05-14 11:46 [PATCH] x86: fix i8259A_resume() Jan Beulich
@ 2012-05-14 15:33 ` Keir Fraser
0 siblings, 0 replies; 2+ messages in thread
From: Keir Fraser @ 2012-05-14 15:33 UTC (permalink / raw)
To: Jan Beulich, xen-devel
On 14/05/2012 12:46, "Jan Beulich" <JBeulich@suse.com> wrote:
> On systems that have an IO-APIC, we generally run the PIC in AEOI
> mode, yet i8259A_resume() so far failed to put it back into that mode.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Keir Fraser <keir@xen.org>
> --- a/xen/arch/x86/i8259.c
> +++ b/xen/arch/x86/i8259.c
> @@ -314,7 +314,7 @@ static void save_ELCR(char *trigger)
>
> int i8259A_resume(void)
> {
> - init_8259A(0);
> + init_8259A(i8259A_irq_type.ack == disable_8259A_irq);
> restore_ELCR(irq_trigger);
> return 0;
> }
>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-05-14 15:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-14 11:46 [PATCH] x86: fix i8259A_resume() Jan Beulich
2012-05-14 15:33 ` Keir Fraser
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).