From: Keir Fraser <keir@xen.org>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xen.org>
Subject: Re: x86: adjust handling of interrupts coming in via legacy vectors
Date: Mon, 14 May 2012 17:24:30 +0100 [thread overview]
Message-ID: <CBD6F04E.40439%keir@xen.org> (raw)
In-Reply-To: <4FB1473102000078000838A6@nat28.tlf.novell.com>
On 14/05/2012 16:56, "Jan Beulich" <JBeulich@suse.com> wrote:
>> Looks sensible, and I suppose good to have for 4.2.
>>
>> Acked-by: Keir Fraser <keir@xen.org>
>
> Please take a look at the v2 I just sent, to accommodate a suggestion
> from Andrew Cooper.
I think it's very paranoid, since legacy vectors never get programmed into
an IOAPIC RTE and should never need EOIing at the local APIC. But you do at
least printk the case that we see the ISR bit set, and you printk the vector
number, so really this v2 patch gives us more information about this bogus
situation than v1 did, so it's a slight improvement overall. So you still
have my Ack.
-- Keir
next prev parent reply other threads:[~2012-05-14 16:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 12:39 x86: adjust handling of interrupts coming in via legacy vectors Jan Beulich
2012-05-14 12:55 ` [PATCH] " Jan Beulich
2012-05-14 13:33 ` Andrew Cooper
2012-05-14 14:28 ` Jan Beulich
2012-05-14 14:38 ` Andrew Cooper
2012-05-14 15:39 ` Jan Beulich
2012-05-14 15:35 ` Keir Fraser
2012-05-14 15:56 ` Jan Beulich
2012-05-14 16:24 ` Keir Fraser [this message]
2012-05-15 6:43 ` Jan Beulich
2012-05-15 8:03 ` AP
2012-05-15 8:22 ` Jan Beulich
2012-05-15 8:52 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CBD6F04E.40439%keir@xen.org \
--to=keir@xen.org \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).