From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir@xen.org>
Subject: Re: x86: adjust handling of interrupts coming in via
 legacy vectors
Date: Mon, 14 May 2012 17:24:30 +0100
Message-ID: <CBD6F04E.40439%keir@xen.org>
References: <4FB1473102000078000838A6@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <4FB1473102000078000838A6@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 14/05/2012 16:56, "Jan Beulich" <JBeulich@suse.com> wrote:

>> Looks sensible, and I suppose good to have for 4.2.
>> 
>> Acked-by: Keir Fraser <keir@xen.org>
> 
> Please take a look at the v2 I just sent, to accommodate a suggestion
> from Andrew Cooper.

I think it's very paranoid, since legacy vectors never get programmed into
an IOAPIC RTE and should never need EOIing at the local APIC. But you do at
least printk the case that we see the ISR bit set, and you printk the vector
number, so really this v2 patch gives us more information about this bogus
situation than v1 did, so it's a slight improvement overall. So you still
have my Ack.

 -- Keir