From: Keir Fraser <keir.xen@gmail.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>, xen-devel@lists.xen.org
Cc: Jan Beulich <JBeulich@suse.com>
Subject: Re: x86_64: Fix double fault stack setup
Date: Thu, 24 May 2012 19:04:51 +0100 [thread overview]
Message-ID: <CBE436D3.342EC%keir.xen@gmail.com> (raw)
In-Reply-To: <4FBE53B7.2080703@citrix.com>
On 24/05/2012 16:28, "Andrew Cooper" <andrew.cooper3@citrix.com> wrote:
> Ah yes - how silly of me. I misread the manual when checking that fact,
> but this was an INT 08 experiment. I really should have checked with a
> ud2 as well.
>
> That is a bit awkward.
>
> Do we actually care about this error from an INT 08? I suppose we could
> check under rip for 0xcd 0x08, but then the same argument would apply to
> all other exceptions which may push an error onto the stack.
>
> Do we care however that entry_vector is not being set correctly? I cant
> see anything on the current codepath which uses it, but it doesn't
> preclude someone adding code in the future.
It would be a simple one-line patch and make that entry point consistent
with all other exception-handling entry points. So I'm in favour of it.
-- Keir
next prev parent reply other threads:[~2012-05-24 18:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-24 14:59 x86_64: Fix double fault stack setup Andrew Cooper
2012-05-24 15:14 ` Jan Beulich
2012-05-24 15:28 ` Andrew Cooper
2012-05-24 15:46 ` Jan Beulich
2012-05-24 16:12 ` Andrew Cooper
2012-05-25 10:35 ` Jan Beulich
2012-05-25 11:04 ` Keir Fraser
2012-05-24 18:04 ` Keir Fraser [this message]
2012-05-24 18:15 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CBE436D3.342EC%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).