From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.xen@gmail.com>
Subject: Re: x86_64: Fix double fault stack setup
Date: Thu, 24 May 2012 19:04:51 +0100
Message-ID: <CBE436D3.342EC%keir.xen@gmail.com>
References: <4FBE53B7.2080703@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <4FBE53B7.2080703@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>, xen-devel@lists.xen.org
Cc: Jan Beulich <JBeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

On 24/05/2012 16:28, "Andrew Cooper" <andrew.cooper3@citrix.com> wrote:

> Ah yes - how silly of me.  I misread the manual when checking that fact,
> but this was an INT 08 experiment.  I really should have checked with a
> ud2 as well.
> 
> That is a bit awkward.
> 
> Do we actually care about this error from an INT 08?  I suppose we could
> check under rip for 0xcd 0x08, but then the same argument would apply to
> all other exceptions which may push an error onto the stack.
> 
> Do we care however that entry_vector is not being set correctly?  I cant
> see anything on the current codepath which uses it, but it doesn't
> preclude someone adding code in the future.

It would be a simple one-line patch and make that entry point consistent
with all other exception-handling entry points. So I'm in favour of it.

 -- Keir