Re: [PATCH 1/3] xen: Add instruction length parameter in function hvm_inject_exception

[Keir Fraser <keir.xen@gmail.com>]

On 28/05/2012 07:24, "Hao, Xudong" <xudong.hao@intel.com> wrote:

> Hi, Keir
> 
> This patch is fine to me, just one small comments: the note below the
> hvm_inject_hw_exception(TRAP*) should change to hvm_inject_hw_exception from
> hvm_inject_exception.

Yes indeed. Thanks!

 -- Keir

> --- a/xen/arch/x86/hvm/svm/nestedsvm.c  Fri May 25 08:21:25 2012 +0100
> +++ b/xen/arch/x86/hvm/svm/nestedsvm.c  Fri May 25 09:45:00 2012 +0100
> @@ -735,7 +735,7 @@ nsvm_vcpu_vmrun(struct vcpu *v, struct c
>      default:
>          gdprintk(XENLOG_ERR,
>              "nsvm_vcpu_vmentry failed, injecting #UD\n");
> -        hvm_inject_exception(TRAP_invalid_op, HVM_DELIVER_NO_ERROR_CODE, 0);
> +        hvm_inject_hw_exception(TRAP_invalid_op, HVM_DELIVER_NO_ERROR_CODE);
>          /* Must happen after hvm_inject_exception or it doesn't work right.
> */
> 
> And I'll add instruction length represented in 'struct hvm_trap', and correct
> the _trap.type in new function vmx_inject_trap() based on the restructuring.
> 
>> 
>>  -- Keir
>