From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.xen@gmail.com>
Subject: Re: [PATCH 1/3] xen: Add instruction length parameter
 in function hvm_inject_exception
Date: Mon, 28 May 2012 07:49:53 +0100
Message-ID: <CBE8DEA1.34527%keir.xen@gmail.com>
References: <403610A45A2B5242BD291EDAE8B37D300FDCA0FF@SHSMSX102.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <403610A45A2B5242BD291EDAE8B37D300FDCA0FF@SHSMSX102.ccr.corp.intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "Hao, Xudong" <xudong.hao@intel.com>, "JBeulich@suse.com" <JBeulich@suse.com>
Cc: Aravindh Puthiyaparambil <aravindh@virtuata.com>, "Dong,
	Eddie" <eddie.dong@intel.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, "Zhang,
	Xiantao" <xiantao.zhang@intel.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 28/05/2012 07:24, "Hao, Xudong" <xudong.hao@intel.com> wrote:

> Hi, Keir
> 
> This patch is fine to me, just one small comments: the note below the
> hvm_inject_hw_exception(TRAP*) should change to hvm_inject_hw_exception from
> hvm_inject_exception.

Yes indeed. Thanks!

 -- Keir

> --- a/xen/arch/x86/hvm/svm/nestedsvm.c  Fri May 25 08:21:25 2012 +0100
> +++ b/xen/arch/x86/hvm/svm/nestedsvm.c  Fri May 25 09:45:00 2012 +0100
> @@ -735,7 +735,7 @@ nsvm_vcpu_vmrun(struct vcpu *v, struct c
>      default:
>          gdprintk(XENLOG_ERR,
>              "nsvm_vcpu_vmentry failed, injecting #UD\n");
> -        hvm_inject_exception(TRAP_invalid_op, HVM_DELIVER_NO_ERROR_CODE, 0);
> +        hvm_inject_hw_exception(TRAP_invalid_op, HVM_DELIVER_NO_ERROR_CODE);
>          /* Must happen after hvm_inject_exception or it doesn't work right.
> */
> 
> And I'll add instruction length represented in 'struct hvm_trap', and correct
> the _trap.type in new function vmx_inject_trap() based on the restructuring.
> 
>> 
>>  -- Keir
>