Re: [PATCH v2 0/4] XEN: fix vmx exception mistake

[Keir Fraser <keir@xen.org>]

On 30/05/2012 12:16, "Hao, Xudong" <xudong.hao@intel.com> wrote:

>> -----Original Message-----
>> From: Keir Fraser [mailto:keir.xen@gmail.com] On Behalf Of Keir Fraser
>> Sent: Wednesday, May 30, 2012 6:40 PM
>> To: Hao, Xudong; JBeulich@suse.com
>> Cc: xen-devel@lists.xen.org; Dong, Eddie; Aravindh Puthiyaparambil; Ian
>> Jackson
>> Subject: Re: [PATCH v2 0/4] XEN: fix vmx exception mistake
>> 
>> On 30/05/2012 03:35, "Xudong Hao" <xudong.hao@intel.com> wrote:
>> 
>>> Changes from v1:
>>> - Define new struct hvm_trap to represent information of trap, include
>>>   instruction length.
>>> - Renames hvm_inject_exception to hvm_inject_trap. Then define a couple of
>>>   wrappers around that function for existing callers, so that their
>>> parameter
>>>   lists actually *shrink*.
>> 
>> I checked in the series, except for the bit that infers trap type from
>> within vmx_inject_trap(). Instead I plumbed through a trap-type field to
>> dom0 toolstack, so the type can be specified by the caller.
>> 
> 
> Thanks, that's more clean.
> 
> The INT3 trap type should be HVMOP_TRAP_sw_exc in
> tools/tests/xen-access/xen-access.c.

Thanks I'll fix it and renam einslen -> insn_len as Jan suggested.

 -- Keir