From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir@xen.org>
Subject: Re: [PATCH] x86/mm: fix mod_l1_entry() return value
 when encountering r/o MMIO page
Date: Wed, 20 Jun 2012 17:04:24 +0100
Message-ID: <CC07B318.434B2%keir@xen.org>
References: <4FE205F1020000780008ADFB@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <4FE205F1020000780008ADFB@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 20/06/2012 16:18, "Jan Beulich" <JBeulich@suse.com> wrote:

> While putting together the workaround announced in
> http://lists.xen.org/archives/html/xen-devel/2012-06/msg00709.html, I
> found that mod_l1_entry(), upon encountering a set bit in
> mmio_ro_ranges, would return 1 instead of 0 (the removal of the write
> permission is supposed to be entirely transparent to the caller, even
> more so to the calling guest).
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Keir Fraser <keir@xen.org>

> --- a/xen/arch/x86/mm.c
> +++ b/xen/arch/x86/mm.c
> @@ -1875,6 +1875,7 @@ static int mod_l1_entry(l1_pgentry_t *pl
>              break;
>          case 1:
>              l1e_remove_flags(nl1e, _PAGE_RW);
> +            rc = 0;
>              break;
>          }
>          if ( page )
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel