From: Keir Fraser <keir.xen@gmail.com>
To: Ian Campbell <Ian.Campbell@citrix.com>,
Anthony PERARD <anthony.perard@citrix.com>
Cc: Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>,
Jan Beulich <jbeulich@suse.com>,
Xen Devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH V2] xen: Fix BUFIOREQ evtchn init for a stubdom.
Date: Fri, 29 Jun 2012 11:12:20 +0100 [thread overview]
Message-ID: <CC133E14.37279%keir.xen@gmail.com> (raw)
In-Reply-To: <1340958413.10942.81.camel@zakaz.uk.xensource.com>
On 29/06/2012 09:26, "Ian Campbell" <Ian.Campbell@citrix.com> wrote:
>> +static int hvm_replace_event_channel(struct vcpu *v, uint64_t remote_domid,
>> + int *port)
int *p_port?...
>> +{
>> + int old_port, new_port;
>> +
>> + new_port = alloc_unbound_xen_event_channel(v, remote_domid, NULL);
>> + if ( new_port < 0 )
>> + return new_port;
>> +
>> + /* xchg() ensures that only we free_xen_event_channel() */
>> + old_port = xchg(port, new_port);
...Would make this line a little bit clearer imo.
>> + free_xen_event_channel(v, old_port);
>> + return 0;
>> +}
>> +
next prev parent reply other threads:[~2012-06-29 10:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-26 15:21 [PATCH V2] xen: Fix BUFIOREQ evtchn init for a stubdom Anthony PERARD
2012-06-29 8:26 ` Ian Campbell
2012-06-29 10:12 ` Keir Fraser [this message]
2012-06-29 8:50 ` Jan Beulich
2012-06-29 10:10 ` Keir Fraser
2012-06-29 10:14 ` Ian Campbell
2012-06-29 10:37 ` Keir Fraser
2012-06-29 10:45 ` Ian Campbell
2012-06-29 10:25 ` Jan Beulich
2012-06-29 11:04 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CC133E14.37279%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=Ian.Campbell@citrix.com \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=anthony.perard@citrix.com \
--cc=jbeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).