From: Keir Fraser <keir@xen.org>
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] serial: don't waste space allocated for the tx buffer(s)
Date: Thu, 26 Jul 2012 16:29:19 +0100 [thread overview]
Message-ID: <CC3720DF.46B5F%keir@xen.org> (raw)
In-Reply-To: <501178C40200007800090A6E@nat28.tlf.novell.com>
On 26/07/2012 16:05, "Jan Beulich" <JBeulich@suse.com> wrote:
> We're allocating minimally a full page, so no reason to not also use
> all that space.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Keir Fraser <keir@xen.org>
> --- a/xen/drivers/char/serial.c
> +++ b/xen/drivers/char/serial.c
> @@ -483,8 +483,8 @@ void __init serial_async_transmit(struct
> BUG_ON(!port->driver->tx_empty);
> if ( port->txbuf != NULL )
> return;
> - if ( serial_txbufsz < 512 )
> - serial_txbufsz = 512;
> + if ( serial_txbufsz < PAGE_SIZE )
> + serial_txbufsz = PAGE_SIZE;
> while ( serial_txbufsz & (serial_txbufsz - 1) )
> serial_txbufsz &= serial_txbufsz - 1;
> port->txbuf = alloc_xenheap_pages(
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
prev parent reply other threads:[~2012-07-26 15:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-26 15:05 [PATCH] serial: don't waste space allocated for the tx buffer(s) Jan Beulich
2012-07-26 15:29 ` Keir Fraser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CC3720DF.46B5F%keir@xen.org \
--to=keir@xen.org \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).