From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir@xen.org>
Subject: Re: [PATCH] serial: don't waste space allocated for the
 tx buffer(s)
Date: Thu, 26 Jul 2012 16:29:19 +0100
Message-ID: <CC3720DF.46B5F%keir@xen.org>
References: <501178C40200007800090A6E@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <501178C40200007800090A6E@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 26/07/2012 16:05, "Jan Beulich" <JBeulich@suse.com> wrote:

> We're allocating minimally a full page, so no reason to not also use
> all that space.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Keir Fraser <keir@xen.org>

> --- a/xen/drivers/char/serial.c
> +++ b/xen/drivers/char/serial.c
> @@ -483,8 +483,8 @@ void __init serial_async_transmit(struct
>      BUG_ON(!port->driver->tx_empty);
>      if ( port->txbuf != NULL )
>          return;
> -    if ( serial_txbufsz < 512 )
> -        serial_txbufsz = 512;
> +    if ( serial_txbufsz < PAGE_SIZE )
> +        serial_txbufsz = PAGE_SIZE;
>      while ( serial_txbufsz & (serial_txbufsz - 1) )
>          serial_txbufsz &= serial_txbufsz - 1;
>      port->txbuf = alloc_xenheap_pages(
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel