From: Keir Fraser <keir@xen.org>
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] x86: fix off-by-one in nr_irqs_gsi calculation
Date: Thu, 26 Jul 2012 16:31:07 +0100 [thread overview]
Message-ID: <CC37214B.46B60%keir@xen.org> (raw)
In-Reply-To: <501179280200007800090A72@nat28.tlf.novell.com>
On 26/07/2012 16:06, "Jan Beulich" <JBeulich@suse.com> wrote:
> highest_gsi() returns the last valid GSI, not a count.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Why not "nr_irqs_gsi = max(nr_irqs_gsi, highest_gsi()+1)"?
> --- a/xen/arch/x86/io_apic.c
> +++ b/xen/arch/x86/io_apic.c
> @@ -2531,7 +2531,9 @@ void __init init_ioapic_mappings(void)
> }
> }
>
> - nr_irqs_gsi = max(nr_irqs_gsi, highest_gsi());
> + i = highest_gsi();
> + if ( i >= nr_irqs_gsi )
> + nr_irqs_gsi = i + 1;
>
> if ( max_gsi_irqs == 0 )
> max_gsi_irqs = nr_irqs ? nr_irqs / 8 : PAGE_SIZE;
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2012-07-26 15:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-26 15:06 [PATCH] x86: fix off-by-one in nr_irqs_gsi calculation Jan Beulich
2012-07-26 15:31 ` Keir Fraser [this message]
2012-07-26 15:43 ` Jan Beulich
2012-07-26 16:27 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CC37214B.46B60%keir@xen.org \
--to=keir@xen.org \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).