From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir@xen.org>
Subject: Re: [PATCH] xen: detect compiler version with
 '--version' rather than '-v'
Date: Thu, 02 Aug 2012 12:24:18 +0100
Message-ID: <CC4021F2.4794F%keir@xen.org>
References: <fdd4b7b36959492b3909.1343905513@whitby.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <fdd4b7b36959492b3909.1343905513@whitby.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Tim Deegan <tim@xen.org>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 02/08/2012 12:05, "Tim Deegan" <tim@xen.org> wrote:

> # HG changeset patch
> # User Tim Deegan <tim@xen.org>
> # Date 1343905471 -3600
> # Node ID fdd4b7b36959492b3909613867360d9993d420a7
> # Parent  3d17148e465ce87ddd8f555a001280348d848419
> xen: detect compiler version with '--version' rather than '-v'
> 
> This allows us to get rid of the 'grep version', which doesn't
> work with localized compilers.

Seem syou've thought about it and tested it more than I ever did.

Acked-by: Keir Fraser <keir@xen.org>

> Signed-off-by: Tim Deegan <tim@xen.org>
> 
> diff -r 3d17148e465c -r fdd4b7b36959 xen/Makefile
> --- a/xen/Makefile Thu Aug 02 11:49:37 2012 +0200
> +++ b/xen/Makefile Thu Aug 02 12:04:31 2012 +0100
> @@ -103,7 +103,7 @@ include/xen/compile.h: include/xen/compi
>    -e 's/@@whoami@@/$(XEN_WHOAMI)/g' \
>    -e 's/@@domain@@/$(XEN_DOMAIN)/g' \
>    -e 's/@@hostname@@/$(shell hostname)/g' \
> -     -e 's!@@compiler@@!$(shell $(CC) $(CFLAGS) -v 2>&1 | grep version | tail
> -1)!g' \
> +     -e 's!@@compiler@@!$(shell $(CC) $(CFLAGS) --version 2>&1 | head -1)!g'
> \
>    -e 's/@@version@@/$(XEN_VERSION)/g' \
>    -e 's/@@subversion@@/$(XEN_SUBVERSION)/g' \
>    -e 's/@@extraversion@@/$(XEN_EXTRAVERSION)/g' \
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel