From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir@xen.org>
Subject: Re: [PATCH v2 5/5] xen: replace XEN_GUEST_HANDLE with
 XEN_GUEST_HANDLE_PARAM when appropriate
Date: Mon, 13 Aug 2012 12:41:30 +0100
Message-ID: <CC4EA67A.48A23%keir@xen.org>
References: <alpine.DEB.2.02.1208131210170.21096@kaball.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <alpine.DEB.2.02.1208131210170.21096@kaball.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>, Jan Beulich <JBeulich@suse.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, "Tim Deegan (3P)" <Tim.Deegan@citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 13/08/2012 12:24, "Stefano Stabellini" <Stefano.Stabellini@eu.citrix.com>
wrote:

>> I can see your point in doing this in the x86 files nevertheless for
>> cosmetic/consistency reasons, but I'm really uncertain about this
>> uglification when it's not really necessary (plus it would shrink the
>> patch quite a bit).
> 
> I don't have a strong opinion on this.
> However it is going to be difficult to enforce XEN_GUEST_HANDLE_PARAM on
> parameters anyway (because we don't have a simple way to make it fail at
> compile time), if we make the change only in xen/commons, it is going to be
> even harder.

It has to be done everywhere, if at all. Else it's an ugly hack job.