[PATCH] x86/ucode: don't crash during AP bringup on non-Intel, non-AMD CPUs

[PATCH] x86/ucode: don't crash during AP bringup on non-Intel, non-AMD CPUs

[Jan Beulich]

[-- Attachment #1: Type: text/plain, Size: 390 bytes --]

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/microcode.c
+++ b/xen/arch/x86/microcode.c
@@ -109,6 +109,9 @@ int microcode_resume_cpu(int cpu)
     struct cpu_signature nsig;
     unsigned int cpu2;
 
+    if ( !microcode_ops )
+        return 0;
+
     spin_lock(&microcode_mutex);
 
     err = microcode_ops->collect_cpu_info(cpu, &uci->cpu_sig);




[-- Attachment #2: x86-ucode-resume-check.patch --]
[-- Type: text/plain, Size: 455 bytes --]

x86/ucode: don't crash during AP bringup on non-Intel, non-AMD CPUs

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/microcode.c
+++ b/xen/arch/x86/microcode.c
@@ -109,6 +109,9 @@ int microcode_resume_cpu(int cpu)
     struct cpu_signature nsig;
     unsigned int cpu2;
 
+    if ( !microcode_ops )
+        return 0;
+
     spin_lock(&microcode_mutex);
 
     err = microcode_ops->collect_cpu_info(cpu, &uci->cpu_sig);

[-- Attachment #3: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH] x86/ucode: don't crash during AP bringup on non-Intel, non-AMD CPUs

[Keir Fraser]

On 16/08/2012 16:22, "Jan Beulich" <JBeulich@suse.com> wrote:

> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Do we support any such processors? Newer VIA processors maybe?

Anyhow,
Acked-by: Keir Fraser <keir@xen.org>

> --- a/xen/arch/x86/microcode.c
> +++ b/xen/arch/x86/microcode.c
> @@ -109,6 +109,9 @@ int microcode_resume_cpu(int cpu)
>      struct cpu_signature nsig;
>      unsigned int cpu2;
>  
> +    if ( !microcode_ops )
> +        return 0;
> +
>      spin_lock(&microcode_mutex);
>  
>      err = microcode_ops->collect_cpu_info(cpu, &uci->cpu_sig);
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel

Re: [PATCH] x86/ucode: don't crash during AP bringup on non-Intel, non-AMD CPUs

[Jan Beulich]

>>> On 16.08.12 at 17:28, Keir Fraser <keir@xen.org> wrote:
> On 16/08/2012 16:22, "Jan Beulich" <JBeulich@suse.com> wrote:
> 
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> Do we support any such processors? Newer VIA processors maybe?

Exactly those - they were kind enough to lend me a system. I'm
having a patch queued for post-4.2 to enable VMX and a few
other vendor specific things on them, but of course a prereq for
testing this was that the system would boot at all under Xen.

Jan

Re: [PATCH] x86/ucode: don't crash during AP bringup on non-Intel, non-AMD CPUs

[Keir Fraser]

On 16/08/2012 16:58, "Jan Beulich" <JBeulich@suse.com> wrote:

>>>> On 16.08.12 at 17:28, Keir Fraser <keir@xen.org> wrote:
>> On 16/08/2012 16:22, "Jan Beulich" <JBeulich@suse.com> wrote:
>> 
>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> 
>> Do we support any such processors? Newer VIA processors maybe?
> 
> Exactly those - they were kind enough to lend me a system. I'm
> having a patch queued for post-4.2 to enable VMX and a few
> other vendor specific things on them, but of course a prereq for
> testing this was that the system would boot at all under Xen.

Very cool! :-)

 -- Keir

> Jan
>