From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [XEN][RFC PATCH V2 01/17] hvm: Modify interface to support multiple ioreq server Date: Thu, 23 Aug 2012 14:26:09 +0100 Message-ID: References: <1345727912.12501.83.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1345727912.12501.83.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Julien Grall Cc: "christian.limpach@gmail.com" , Stefano Stabellini , "qemu-devel@nongnu.org" , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On 23/08/2012 14:18, "Ian Campbell" wrote: >> diff --git a/xen/include/public/hvm/ioreq.h b/xen/include/public/hvm/ioreq.h >> index 4022a1d..87aacd3 100644 >> --- a/xen/include/public/hvm/ioreq.h >> +++ b/xen/include/public/hvm/ioreq.h >> @@ -34,6 +34,7 @@ >> >> #define IOREQ_TYPE_PIO 0 /* pio */ >> #define IOREQ_TYPE_COPY 1 /* mmio ops */ >> +#define IOREQ_TYPE_PCI_CONFIG 2 /* pci config space ops */ >> #define IOREQ_TYPE_TIMEOFFSET 7 >> #define IOREQ_TYPE_INVALIDATE 8 /* mapcache */ > > I wonder why we skip 2-6 now -- perhaps they used to be something else > and we are avoiding them to avoid strange errors? In which case adding > the new on as 9 might be a good idea. They were almost certainly used for representing R-M-W ALU operations back in the days of the old IO emulator, very long ago. Still, there's no harm in leaving them unused. -- Keir