From: Keir Fraser <keir.xen@gmail.com>
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH 2/2] x86: fix RCU locking in PHYSDEVOP_get_free_pirq
Date: Wed, 05 Sep 2012 14:53:18 +0100 [thread overview]
Message-ID: <CC6D17DE.3DCD9%keir.xen@gmail.com> (raw)
In-Reply-To: <504765830200007800098E5D@nat28.tlf.novell.com>
On 05/09/2012 13:45, "Jan Beulich" <JBeulich@suse.com> wrote:
>>> Apart from properly pairing locks with unlocks, also reduce the lock
>>> scope - no need to do the copy_{from,to}_guest()-s inside the protected
>>> region.
>>>
>>> I actually wonder whether the RCU locks are needed here at all.
>>
>> If it's a path that only acts on current domain, then no.
>
> So for what case does rcu_lock_current_domain() then exist at all?
To match an unconditional rcu_unlock_domain() on exit paths, for operations
which can either be on current->domain or on a rcu_lock_domain_by_id().
-- Keir
prev parent reply other threads:[~2012-09-05 13:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 12:25 [PATCH 2/2] x86: fix RCU locking in PHYSDEVOP_get_free_pirq Jan Beulich
2012-09-05 12:33 ` Keir Fraser
2012-09-05 12:45 ` Jan Beulich
2012-09-05 13:53 ` Keir Fraser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CC6D17DE.3DCD9%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).