From: Keir Fraser <keir.xen@gmail.com>
To: Jan Beulich <JBeulich@suse.com>, David Vrabel <david.vrabel@citrix.com>
Cc: xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] timer: remove stray local_irq_enable()
Date: Thu, 06 Sep 2012 14:28:02 +0100 [thread overview]
Message-ID: <CC6E6372.3DE4C%keir.xen@gmail.com> (raw)
In-Reply-To: <5048B27F0200007800099535@nat28.tlf.novell.com>
On 06/09/2012 13:26, "Jan Beulich" <JBeulich@suse.com> wrote:
>>>> On 06.09.12 at 14:05, David Vrabel <david.vrabel@citrix.com> wrote:
>> From: David Vrabel <david.vrabel@citrix.com>
>>
>> migrate_timers_from_cpu() has a stray local_irq_enable() that does
>> nothing (it's immediately after a spin_unlock_irq()) and has no
>> matching local_irq_disable().
>>
>> Signed-off-by: David Vrabel <david.vrabel@citrix.com>
>
> Acked-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Keir Fraser <keir@xen.org>
Jan, Please apply it to xen-unstable.
-- Keir
>> --- a/xen/common/timer.c
>> +++ b/xen/common/timer.c
>> @@ -587,7 +587,6 @@ static void migrate_timers_from_cpu(unsigned int old_cpu)
>>
>> spin_unlock(&old_ts->lock);
>> spin_unlock_irq(&new_ts->lock);
>> - local_irq_enable();
>>
>> if ( notify )
>> cpu_raise_softirq(new_cpu, TIMER_SOFTIRQ);
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
prev parent reply other threads:[~2012-09-06 13:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 12:05 [PATCH] timer: remove stray local_irq_enable() David Vrabel
2012-09-06 12:26 ` Jan Beulich
2012-09-06 13:28 ` Keir Fraser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CC6E6372.3DE4C%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=JBeulich@suse.com \
--cc=david.vrabel@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).