From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.xen@gmail.com>
Subject: Re: [PATCH] timer: remove stray local_irq_enable()
Date: Thu, 06 Sep 2012 14:28:02 +0100
Message-ID: <CC6E6372.3DE4C%keir.xen@gmail.com>
References: <5048B27F0200007800099535@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5048B27F0200007800099535@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, David Vrabel <david.vrabel@citrix.com>
Cc: xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 06/09/2012 13:26, "Jan Beulich" <JBeulich@suse.com> wrote:

>>>> On 06.09.12 at 14:05, David Vrabel <david.vrabel@citrix.com> wrote:
>> From: David Vrabel <david.vrabel@citrix.com>
>> 
>> migrate_timers_from_cpu() has a stray local_irq_enable() that does
>> nothing (it's immediately after a spin_unlock_irq()) and has no
>> matching local_irq_disable().
>> 
>> Signed-off-by: David Vrabel <david.vrabel@citrix.com>
> 
> Acked-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Keir Fraser <keir@xen.org>

Jan, Please apply it to xen-unstable.

 -- Keir

>> --- a/xen/common/timer.c
>> +++ b/xen/common/timer.c
>> @@ -587,7 +587,6 @@ static void migrate_timers_from_cpu(unsigned int old_cpu)
>>  
>>      spin_unlock(&old_ts->lock);
>>      spin_unlock_irq(&new_ts->lock);
>> -    local_irq_enable();
>>  
>>      if ( notify )
>>          cpu_raise_softirq(new_cpu, TIMER_SOFTIRQ);
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel