From: Keir Fraser <keir.xen@gmail.com>
To: Jan Beulich <JBeulich@suse.com>, Ian Campbell <Ian.Campbell@citrix.com>
Cc: "Tim (Xen.org)" <tim@xen.org>,
Dario Faggioli <dario.faggioli@citrix.com>,
"Keir (Xen.org)" <keir@xen.org>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH] xen: clamp bitmaps to correct number of bits
Date: Thu, 06 Sep 2012 16:51:43 +0100 [thread overview]
Message-ID: <CC6E851F.3DE9F%keir.xen@gmail.com> (raw)
In-Reply-To: <5048D39D0200007800099684@nat28.tlf.novell.com>
On 06/09/2012 15:47, "Jan Beulich" <JBeulich@suse.com> wrote:
>> I'll fold them in, it was convenient to have variables while I was
>> printk'ing what I was doing but not any more.
>
> I won't ask you for another round because of this, but you
> still left the parameter and remaining local variable as plain
> int, nor did you insert whitespace into the expressions. If I
> were the one to commit this, I would do the adjustment while
> committing...
>
> Anyway, as long as there's no easily visible tools side bug
> addressed by this, I would think we should rather leave this
> for after branching - Keir?
Yes, we'll leave it for post 4.2.0.
next prev parent reply other threads:[~2012-09-06 15:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 11:56 [PATCH] xen: clamp bitmaps to correct number of bits Ian Campbell
2012-09-06 12:23 ` Jan Beulich
2012-09-06 13:48 ` Ian Campbell
2012-09-06 14:47 ` Jan Beulich
2012-09-06 15:51 ` Keir Fraser [this message]
2012-09-06 16:20 ` Ian Campbell
2012-09-07 8:17 ` Jan Beulich
2012-09-07 8:23 ` Ian Campbell
2012-09-07 8:33 ` Jan Beulich
2012-09-07 9:20 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CC6E851F.3DE9F%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=Ian.Campbell@citrix.com \
--cc=JBeulich@suse.com \
--cc=dario.faggioli@citrix.com \
--cc=keir@xen.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).