From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.xen@gmail.com>
Subject: Re: [PATCH] xen: clamp bitmaps to correct number of bits
Date: Thu, 06 Sep 2012 16:51:43 +0100
Message-ID: <CC6E851F.3DE9F%keir.xen@gmail.com>
References: <5048D39D0200007800099684@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5048D39D0200007800099684@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, Ian Campbell <Ian.Campbell@citrix.com>
Cc: "Tim (Xen.org)" <tim@xen.org>, Dario Faggioli <dario.faggioli@citrix.com>, "Keir (Xen.org)" <keir@xen.org>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 06/09/2012 15:47, "Jan Beulich" <JBeulich@suse.com> wrote:

>> I'll fold them in, it was convenient to have variables while I was
>> printk'ing what I was doing but not any more.
> 
> I won't ask you for another round because of this, but you
> still left the parameter and remaining local variable as plain
> int, nor did you insert whitespace into the expressions. If I
> were the one to commit this, I would do the adjustment while
> committing...
> 
> Anyway, as long as there's no easily visible tools side bug
> addressed by this, I would think we should rather leave this
> for after branching - Keir?

Yes, we'll leave it for post 4.2.0.