From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir@xen.org>
Subject: Re: [PATCH] PCI: bus scan adjustments
Date: Tue, 11 Sep 2012 14:11:50 +0100
Message-ID: <CC74F726.4B6F6%keir@xen.org>
References: <504F3CC7020000780009A8C7@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <504F3CC7020000780009A8C7@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 11/09/2012 12:29, "Jan Beulich" <JBeulich@suse.com> wrote:

> As done elsewhere, the ns16550 code shouldn't look at non-zero
> functions of a device if that isn't multi-function.
> 
> Also both there and in pass-through's _scan_pci_devices() skip looking
> at non-zero functions when the device at function zero doesn't exist.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> Note that to apply cleanly, this has to go on top of the serial console
> improvement series posted earlier.

Acked-by: Keir Fraser <keir@xen.org>

> --- a/xen/drivers/char/ns16550.c
> +++ b/xen/drivers/char/ns16550.c
> @@ -470,21 +470,28 @@ static int
>  pci_uart_config (struct ns16550 *uart, int skip_amt, int bar_idx)
>  {
>      uint32_t bar, len;
> -    int b, d, f;
> +    int b, d, f, nextf;
>  
>      /* NB. Start at bus 1 to avoid AMT: a plug-in card cannot be on bus 0. */
>      for ( b = skip_amt ? 1 : 0; b < 0x100; b++ )
>      {
>          for ( d = 0; d < 0x20; d++ )
>          {
> -            for ( f = 0; f < 0x8; f++ )
> +            for ( f = 0; f < 8; f = nextf )
>              {
> +                nextf = (f || (pci_conf_read16(0, b, d, f, PCI_HEADER_TYPE) &
> +                               0x80)) ? f + 1 : 8;
> +
>                  switch ( pci_conf_read16(0, b, d, f, PCI_CLASS_DEVICE) )
>                  {
>                  case 0x0700: /* single port serial */
>                  case 0x0702: /* multi port serial */
>                  case 0x0780: /* other (e.g serial+parallel) */
>                      break;
> +                case 0xffff:
> +                    if ( !f )
> +                        nextf = 8;
> +                    /* fall through */
>                  default:
>                      continue;
>                  }
> --- a/xen/drivers/passthrough/pci.c
> +++ b/xen/drivers/passthrough/pci.c
> @@ -665,7 +665,11 @@ static int __init _scan_pci_devices(stru
>              for ( func = 0; func < 8; func++ )
>              {
>                  if ( pci_device_detect(pseg->nr, bus, dev, func) == 0 )
> +                {
> +                    if ( !func )
> +                        break;
>                      continue;
> +                }
>  
>                  pdev = alloc_pdev(pseg, bus, PCI_DEVFN(dev, func));
>                  if ( !pdev )
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel