* [PATCH] tools: drop ia64 only foreign structs from headers
@ 2012-09-14 10:00 Ian Campbell
2012-09-14 10:05 ` Jan Beulich
2012-09-14 12:23 ` Keir Fraser
0 siblings, 2 replies; 6+ messages in thread
From: Ian Campbell @ 2012-09-14 10:00 UTC (permalink / raw)
To: xen-devel; +Cc: Jan Beulich
# HG changeset patch
# User Ian Campbell <ian.campbell@citrix.com>
# Date 1347616748 -3600
# Node ID 640a0b0b44e67c8434735c5129400b3a56a43683
# Parent aabf685cd613b11e9b9709ae2a43f23f56d4d7ff
tools: drop ia64 only foreign structs from headers
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
diff -r aabf685cd613 -r 640a0b0b44e6 tools/include/xen-foreign/reference.size
--- a/tools/include/xen-foreign/reference.size Fri Sep 14 10:39:09 2012 +0100
+++ b/tools/include/xen-foreign/reference.size Fri Sep 14 10:59:08 2012 +0100
@@ -3,12 +3,7 @@ structs | x86_32 x86
start_info | 1112 1168
trap_info | 8 16
-pt_fpreg | - -
cpu_user_regs | 68 200
-xen_ia64_boot_param | - -
-ia64_tr_entry | - -
-vcpu_tr_regs | - -
-vcpu_guest_context_regs | - -
vcpu_guest_context | 2800 5168
arch_vcpu_info | 24 16
vcpu_time_info | 32 32
diff -r aabf685cd613 -r 640a0b0b44e6 tools/include/xen-foreign/structs.py
--- a/tools/include/xen-foreign/structs.py Fri Sep 14 10:39:09 2012 +0100
+++ b/tools/include/xen-foreign/structs.py Fri Sep 14 10:59:08 2012 +0100
@@ -5,12 +5,7 @@ unions = [ "vcpu_cr_regs",
structs = [ "start_info",
"trap_info",
- "pt_fpreg",
"cpu_user_regs",
- "xen_ia64_boot_param",
- "ia64_tr_entry",
- "vcpu_tr_regs",
- "vcpu_guest_context_regs",
"vcpu_guest_context",
"arch_vcpu_info",
"vcpu_time_info",
@@ -48,9 +43,6 @@ defines = [ "__i386__",
"_VGCF_online",
"VGCF_online",
- # ia64
- "VGCF_EXTRA_REGS",
-
# all archs
"xen_pfn_to_cr3",
"xen_cr3_to_pfn",
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tools: drop ia64 only foreign structs from headers
2012-09-14 10:00 [PATCH] tools: drop ia64 only foreign structs from headers Ian Campbell
@ 2012-09-14 10:05 ` Jan Beulich
2012-09-14 10:45 ` Ian Campbell
2012-09-17 10:18 ` Ian Campbell
2012-09-14 12:23 ` Keir Fraser
1 sibling, 2 replies; 6+ messages in thread
From: Jan Beulich @ 2012-09-14 10:05 UTC (permalink / raw)
To: Ian Campbell; +Cc: xen-devel
>>> On 14.09.12 at 12:00, Ian Campbell <ian.campbell@citrix.com> wrote:
> # HG changeset patch
> # User Ian Campbell <ian.campbell@citrix.com>
> # Date 1347616748 -3600
> # Node ID 640a0b0b44e67c8434735c5129400b3a56a43683
> # Parent aabf685cd613b11e9b9709ae2a43f23f56d4d7ff
> tools: drop ia64 only foreign structs from headers
Not sure why they got put there in the first place.
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
> diff -r aabf685cd613 -r 640a0b0b44e6 tools/include/xen-foreign/reference.size
> --- a/tools/include/xen-foreign/reference.size Fri Sep 14 10:39:09 2012 +0100
> +++ b/tools/include/xen-foreign/reference.size Fri Sep 14 10:59:08 2012 +0100
> @@ -3,12 +3,7 @@ structs | x86_32 x86
>
> start_info | 1112 1168
> trap_info | 8 16
> -pt_fpreg | - -
> cpu_user_regs | 68 200
> -xen_ia64_boot_param | - -
> -ia64_tr_entry | - -
> -vcpu_tr_regs | - -
> -vcpu_guest_context_regs | - -
> vcpu_guest_context | 2800 5168
> arch_vcpu_info | 24 16
> vcpu_time_info | 32 32
> diff -r aabf685cd613 -r 640a0b0b44e6 tools/include/xen-foreign/structs.py
> --- a/tools/include/xen-foreign/structs.py Fri Sep 14 10:39:09 2012 +0100
> +++ b/tools/include/xen-foreign/structs.py Fri Sep 14 10:59:08 2012 +0100
> @@ -5,12 +5,7 @@ unions = [ "vcpu_cr_regs",
>
> structs = [ "start_info",
> "trap_info",
> - "pt_fpreg",
> "cpu_user_regs",
> - "xen_ia64_boot_param",
> - "ia64_tr_entry",
> - "vcpu_tr_regs",
> - "vcpu_guest_context_regs",
> "vcpu_guest_context",
> "arch_vcpu_info",
> "vcpu_time_info",
> @@ -48,9 +43,6 @@ defines = [ "__i386__",
> "_VGCF_online",
> "VGCF_online",
>
> - # ia64
> - "VGCF_EXTRA_REGS",
> -
> # all archs
> "xen_pfn_to_cr3",
> "xen_cr3_to_pfn",
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tools: drop ia64 only foreign structs from headers
2012-09-14 10:05 ` Jan Beulich
@ 2012-09-14 10:45 ` Ian Campbell
2012-09-14 11:36 ` Jan Beulich
2012-09-17 10:18 ` Ian Campbell
1 sibling, 1 reply; 6+ messages in thread
From: Ian Campbell @ 2012-09-14 10:45 UTC (permalink / raw)
To: Jan Beulich; +Cc: xen-devel@lists.xen.org
On Fri, 2012-09-14 at 11:05 +0100, Jan Beulich wrote:
> >>> On 14.09.12 at 12:00, Ian Campbell <ian.campbell@citrix.com> wrote:
> > # HG changeset patch
> > # User Ian Campbell <ian.campbell@citrix.com>
> > # Date 1347616748 -3600
> > # Node ID 640a0b0b44e67c8434735c5129400b3a56a43683
> > # Parent aabf685cd613b11e9b9709ae2a43f23f56d4d7ff
> > tools: drop ia64 only foreign structs from headers
>
> Not sure why they got put there in the first place.
What are the criteria to be listed here? I was surprised how short the
list was...
>
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
>
> Acked-by: Jan Beulich <jbeulich@suse.com>
Thanks.
>
> > diff -r aabf685cd613 -r 640a0b0b44e6 tools/include/xen-foreign/reference.size
> > --- a/tools/include/xen-foreign/reference.size Fri Sep 14 10:39:09 2012 +0100
> > +++ b/tools/include/xen-foreign/reference.size Fri Sep 14 10:59:08 2012 +0100
> > @@ -3,12 +3,7 @@ structs | x86_32 x86
> >
> > start_info | 1112 1168
> > trap_info | 8 16
> > -pt_fpreg | - -
> > cpu_user_regs | 68 200
> > -xen_ia64_boot_param | - -
> > -ia64_tr_entry | - -
> > -vcpu_tr_regs | - -
> > -vcpu_guest_context_regs | - -
> > vcpu_guest_context | 2800 5168
> > arch_vcpu_info | 24 16
> > vcpu_time_info | 32 32
> > diff -r aabf685cd613 -r 640a0b0b44e6 tools/include/xen-foreign/structs.py
> > --- a/tools/include/xen-foreign/structs.py Fri Sep 14 10:39:09 2012 +0100
> > +++ b/tools/include/xen-foreign/structs.py Fri Sep 14 10:59:08 2012 +0100
> > @@ -5,12 +5,7 @@ unions = [ "vcpu_cr_regs",
> >
> > structs = [ "start_info",
> > "trap_info",
> > - "pt_fpreg",
> > "cpu_user_regs",
> > - "xen_ia64_boot_param",
> > - "ia64_tr_entry",
> > - "vcpu_tr_regs",
> > - "vcpu_guest_context_regs",
> > "vcpu_guest_context",
> > "arch_vcpu_info",
> > "vcpu_time_info",
> > @@ -48,9 +43,6 @@ defines = [ "__i386__",
> > "_VGCF_online",
> > "VGCF_online",
> >
> > - # ia64
> > - "VGCF_EXTRA_REGS",
> > -
> > # all archs
> > "xen_pfn_to_cr3",
> > "xen_cr3_to_pfn",
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tools: drop ia64 only foreign structs from headers
2012-09-14 10:45 ` Ian Campbell
@ 2012-09-14 11:36 ` Jan Beulich
0 siblings, 0 replies; 6+ messages in thread
From: Jan Beulich @ 2012-09-14 11:36 UTC (permalink / raw)
To: Ian Campbell; +Cc: xen-devel@lists.xen.org
>>> On 14.09.12 at 12:45, Ian Campbell <Ian.Campbell@citrix.com> wrote:
> On Fri, 2012-09-14 at 11:05 +0100, Jan Beulich wrote:
>> >>> On 14.09.12 at 12:00, Ian Campbell <ian.campbell@citrix.com> wrote:
>> > # HG changeset patch
>> > # User Ian Campbell <ian.campbell@citrix.com>
>> > # Date 1347616748 -3600
>> > # Node ID 640a0b0b44e67c8434735c5129400b3a56a43683
>> > # Parent aabf685cd613b11e9b9709ae2a43f23f56d4d7ff
>> > tools: drop ia64 only foreign structs from headers
>>
>> Not sure why they got put there in the first place.
>
> What are the criteria to be listed here? I was surprised how short the
> list was...
Don't know, this got introduced by Gerd Hoffmann, who I think
hasn't been working on Xen anymore for years. I believe this is
on an as-needed-by-the-tools basis.
Jan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tools: drop ia64 only foreign structs from headers
2012-09-14 10:00 [PATCH] tools: drop ia64 only foreign structs from headers Ian Campbell
2012-09-14 10:05 ` Jan Beulich
@ 2012-09-14 12:23 ` Keir Fraser
1 sibling, 0 replies; 6+ messages in thread
From: Keir Fraser @ 2012-09-14 12:23 UTC (permalink / raw)
To: Ian Campbell, xen-devel; +Cc: Jan Beulich
On 14/09/2012 11:00, "Ian Campbell" <ian.campbell@citrix.com> wrote:
> # HG changeset patch
> # User Ian Campbell <ian.campbell@citrix.com>
> # Date 1347616748 -3600
> # Node ID 640a0b0b44e67c8434735c5129400b3a56a43683
> # Parent aabf685cd613b11e9b9709ae2a43f23f56d4d7ff
> tools: drop ia64 only foreign structs from headers
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Keir Fraser <keir@xen.org>
> diff -r aabf685cd613 -r 640a0b0b44e6 tools/include/xen-foreign/reference.size
> --- a/tools/include/xen-foreign/reference.size Fri Sep 14 10:39:09 2012 +0100
> +++ b/tools/include/xen-foreign/reference.size Fri Sep 14 10:59:08 2012 +0100
> @@ -3,12 +3,7 @@ structs | x86_32 x86
>
> start_info | 1112 1168
> trap_info | 8 16
> -pt_fpreg | - -
> cpu_user_regs | 68 200
> -xen_ia64_boot_param | - -
> -ia64_tr_entry | - -
> -vcpu_tr_regs | - -
> -vcpu_guest_context_regs | - -
> vcpu_guest_context | 2800 5168
> arch_vcpu_info | 24 16
> vcpu_time_info | 32 32
> diff -r aabf685cd613 -r 640a0b0b44e6 tools/include/xen-foreign/structs.py
> --- a/tools/include/xen-foreign/structs.py Fri Sep 14 10:39:09 2012 +0100
> +++ b/tools/include/xen-foreign/structs.py Fri Sep 14 10:59:08 2012 +0100
> @@ -5,12 +5,7 @@ unions = [ "vcpu_cr_regs",
>
> structs = [ "start_info",
> "trap_info",
> - "pt_fpreg",
> "cpu_user_regs",
> - "xen_ia64_boot_param",
> - "ia64_tr_entry",
> - "vcpu_tr_regs",
> - "vcpu_guest_context_regs",
> "vcpu_guest_context",
> "arch_vcpu_info",
> "vcpu_time_info",
> @@ -48,9 +43,6 @@ defines = [ "__i386__",
> "_VGCF_online",
> "VGCF_online",
>
> - # ia64
> - "VGCF_EXTRA_REGS",
> -
> # all archs
> "xen_pfn_to_cr3",
> "xen_cr3_to_pfn",
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tools: drop ia64 only foreign structs from headers
2012-09-14 10:05 ` Jan Beulich
2012-09-14 10:45 ` Ian Campbell
@ 2012-09-17 10:18 ` Ian Campbell
1 sibling, 0 replies; 6+ messages in thread
From: Ian Campbell @ 2012-09-17 10:18 UTC (permalink / raw)
To: Jan Beulich; +Cc: xen-devel@lists.xen.org
On Fri, 2012-09-14 at 11:05 +0100, Jan Beulich wrote:
> >>> On 14.09.12 at 12:00, Ian Campbell <ian.campbell@citrix.com> wrote:
> > # HG changeset patch
> > # User Ian Campbell <ian.campbell@citrix.com>
> > # Date 1347616748 -3600
> > # Node ID 640a0b0b44e67c8434735c5129400b3a56a43683
> > # Parent aabf685cd613b11e9b9709ae2a43f23f56d4d7ff
> > tools: drop ia64 only foreign structs from headers
>
> Not sure why they got put there in the first place.
>
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
>
> Acked-by: Jan Beulich <jbeulich@suse.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-09-17 10:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-14 10:00 [PATCH] tools: drop ia64 only foreign structs from headers Ian Campbell
2012-09-14 10:05 ` Jan Beulich
2012-09-14 10:45 ` Ian Campbell
2012-09-14 11:36 ` Jan Beulich
2012-09-17 10:18 ` Ian Campbell
2012-09-14 12:23 ` Keir Fraser
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).