From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] ACPI: move tables.c fully into .init.* Date: Wed, 19 Sep 2012 08:56:15 +0100 Message-ID: References: <5059905E020000780009C394@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5059905E020000780009C394@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel List-Id: xen-devel@lists.xenproject.org On 19/09/2012 08:29, "Jan Beulich" wrote: >>>> On 18.09.12 at 17:42, Keir Fraser wrote: >> On 18/09/2012 16:26, "Jan Beulich" wrote: >> >>> The only non-init item was the space reserved for the initial tables, >>> but we can as well dynamically allocate that array. >>> >>> Signed-off-by: Jan Beulich >> >> Really worthwhile, versus having to round up the initial_tables[] allocation >> to a whole number of pages? > > It was exactly one page in size already. Well, still I'm not sure about the style of converting static data to heap data, just to be able to mark a whole unit init-only. If everything else is already marked init inside that file already, is there a win? -- Keir > Jan >