From: Keir Fraser <keir.xen@gmail.com>
To: Ben Guthro <ben@guthro.net>, Jan Beulich <JBeulich@suse.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
john.baboval@citrix.com, Thomas Goetz <thomas.goetz@citrix.com>,
xen-devel <xen-devel@lists.xen.org>
Subject: Re: Xen4.2 S3 regression?
Date: Fri, 21 Sep 2012 07:34:43 +0100 [thread overview]
Message-ID: <CC81C913.3F4B0%keir.xen@gmail.com> (raw)
In-Reply-To: <CAOvdn6XFy_Teo0x8rBYvY1j+=ZEDAeE4bZ359nVOtgUyb=ZJig@mail.gmail.com>
On 20/09/2012 21:30, "Ben Guthro" <ben@guthro.net> wrote:
> (XEN) Bringing CPU1 down
> (XEN) Disabling CPU1
> (XEN) Disabled CPU1
> (XEN) play_dead: CPU1
> (XEN) cpu_exit_clear: CPU1
> (XEN) cpu_uninit: CPU1
> (XEN) CPU1 dead
So CPU1 is taken down properly, apparently...
> (XEN) Entering ACPI S3 state.
... During S3 suspend.
> (XEN) Finishing wakeup from ACPI S3 state.
> (XEN) Enabling non-boot CPUs ...
> (XEN) Bringing CPU1 up
> (XEN) Setting warm reset code and vector.
> (XEN) Asserting INIT.
> (XEN) Waiting for send to finish...
> (XEN) +Deasserting INIT.
> (XEN) Waiting for send to finish...
> (XEN) +#startup loops: 2.
> (XEN) Sending STARTUP #1.
> (XEN) After apic_write.
> (XEN) CPU#1 already initialized!
But here CPU1 thinks it is already initialised! *This* is the bug you need
to go look at. CPU1 will spin at this point...
> (XEN) Startup point 1.
> (XEN) Waiting for send to finish...
> (XEN) +Sending STARTUP #2.
> (XEN) After apic_write.
> (XEN) Startup point 1.
> (XEN) Waiting for send to finish...
> (XEN) +After Startup.
> (XEN) After Callout 1.
> (XEN) Stuck ??
...Causing CPU0 to think CPU1 is stuck (which is fair, because it is).
> (XEN) cpu_exit_clear: CPU1
> (XEN) cpu_uninit: CPU1
> (XEN) __cpu_up - do_boot_cpu error
> (XEN) cpu_up CPU1 CPU not up
> (XEN) cpu_up CPU1 fail
> (XEN) Error taking CPU1 up: -5
> [ 32.780055] ACPI: Low-level resume complete
> [ 32.780055] PM: Restoring platform NVS memory
> [ 32.780055] Enabling non-boot CPUs ...
>
> then it crashes.
>
> It seems that it is always falling through into the "else" clause of
> the do_boot_cpu() function when attempting to bring it back up, seemingly
> stuck in CPU_STATE_CALLOUT
>
> Any ideas as to what might be causing it to get stuck in that state?
Yes, see explanation above, which is actually the same explanation I gave
you before. You need to go investigate why CPU1 is getting confused in
cpu_init().
-- Keir
>
>
>
>
>> I put a cpu id conditional BUG() call in there, to verify - and while it is
>> reached when using
>> xen-hptool cpu-offline 1
>> It never seems to be reached from the S3 path.
>>
>>
>> What is the expected call chain to get into this code during S3?
>>
>>
>> On Thu, Sep 20, 2012 at 4:03 AM, Jan Beulich <JBeulich@suse.com> wrote:
>>>>>> On 20.09.12 at 08:13, Keir Fraser <keir.xen@gmail.com> wrote:
>>>> CPU#1 got stuck in loop in cpu_init() as it appears to be Œalready
>>>> initialised¹ in cpu_initialized bitmap. CPU#0 detects it is stuck and
>>>> carries on, but the resume code assumes all CPUs are brought back online
>>>> and
>>>> crashes later.
>>>
>>> So this would suggest play_dead() (-> cpu_exit_clear() ->
>>> cpu_uninit()) not getting reached during the suspend cycle.
>>> That should be fairly easy to verify, as the serial console
>>> ought to still work when the secondary CPUs get offlined.
>>>
>>> That might imply cpumask_clear_cpu(cpu, &cpu_online_map)
>>> not getting reached in __cpu_disable(), which would be in line
>>> with the observation that none of the logs provided so far
>>> showed anything being done by fixup_irqs() (called right
>>> after clearing the online bit).
>>>
>>> Jan
>>
>
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2012-09-21 6:34 UTC|newest]
Thread overview: 134+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-07 15:04 Xen4.2 S3 regression? Ben Guthro
2012-08-07 16:21 ` Ben Guthro
2012-08-07 16:33 ` Konrad Rzeszutek Wilk
2012-08-07 16:48 ` Ben Guthro
2012-08-07 20:14 ` Ben Guthro
2012-08-08 8:35 ` Jan Beulich
2012-08-08 10:39 ` Ben Guthro
2012-08-09 15:21 ` Ben Guthro
2012-08-09 15:37 ` Jan Beulich
2012-08-09 15:46 ` Ben Guthro
2012-08-09 15:51 ` Jan Beulich
2012-08-09 16:09 ` Ben Guthro
2012-08-10 6:50 ` Jan Beulich
2012-08-10 19:15 ` Ben Guthro
2012-08-14 17:31 ` Ben Guthro
2012-08-15 8:11 ` Jan Beulich
2012-08-15 10:32 ` Ben Guthro
2012-08-15 12:32 ` Ben Guthro
2012-08-15 12:58 ` Jan Beulich
2012-08-15 13:11 ` Ben Guthro
2012-08-15 14:50 ` Jan Beulich
2012-08-15 14:58 ` Ben Guthro
2012-08-15 15:00 ` Andrew Cooper
2012-08-15 15:06 ` Jan Beulich
2012-08-15 15:16 ` Ben Guthro
2012-08-16 8:31 ` Jan Beulich
2012-08-16 10:37 ` Ben Guthro
2012-08-16 11:07 ` Jan Beulich
2012-08-16 11:56 ` Ben Guthro
2012-08-17 10:22 ` Ben Guthro
2012-08-17 10:40 ` Jan Beulich
2012-08-23 18:03 ` Ben Guthro
2012-08-23 18:37 ` Andrew Cooper
2012-08-24 22:11 ` Jan Beulich
2012-08-24 22:55 ` Jan Beulich
2012-08-25 0:48 ` Ben Guthro
2012-09-03 9:31 ` Jan Beulich
2012-09-04 12:27 ` Ben Guthro
2012-09-04 12:49 ` Ben Guthro
2012-09-04 14:26 ` Jan Beulich
2012-09-04 14:28 ` Ben Guthro
2012-09-04 14:36 ` Konrad Rzeszutek Wilk
2012-09-04 15:02 ` Jan Beulich
2012-09-06 10:22 ` Jan Beulich
2012-09-06 11:48 ` Ben Guthro
2012-09-06 11:51 ` Ben Guthro
2012-09-06 13:05 ` Konrad Rzeszutek Wilk
2012-09-06 13:27 ` Ben Guthro
2012-09-06 13:36 ` Ben Guthro
2012-09-06 16:42 ` Ben Guthro
2012-09-07 8:38 ` Jan Beulich
2012-09-07 10:37 ` Ben Guthro
2012-09-07 11:15 ` Jan Beulich
2012-09-07 11:51 ` Ben Guthro
2012-09-07 12:18 ` Jan Beulich
2012-09-07 16:06 ` Ben Guthro
2012-09-19 21:07 ` Ben Guthro
2012-09-20 6:13 ` Keir Fraser
2012-09-20 6:24 ` Keir Fraser
2012-09-20 8:03 ` Jan Beulich
2012-09-20 8:14 ` Keir Fraser
2012-09-20 12:56 ` Ben Guthro
2012-09-20 13:07 ` Keir Fraser
2012-09-20 20:30 ` Ben Guthro
2012-09-21 6:34 ` Keir Fraser [this message]
2012-09-21 6:47 ` Jan Beulich
2012-09-21 18:20 ` Ben Guthro
2012-09-21 18:42 ` Keir Fraser
2012-09-24 11:22 ` Jan Beulich
2012-09-24 11:25 ` Ben Guthro
2012-09-24 11:45 ` Jan Beulich
2012-09-24 11:54 ` Ben Guthro
2012-09-24 12:05 ` Jan Beulich
2012-09-24 12:24 ` Ben Guthro
2012-09-24 12:32 ` Jan Beulich
[not found] ` <CAOvdn6UMHmPWqedYE9GQQMDaM4oiHLDSn9ZzSgJjGf89g1DgTw@mail.gmail.com>
[not found] ` <50607D70020000780009D5C3@nat28.tlf.novell.com>
[not found] ` <CAOvdn6XL9ebp2oUV0XEXk_WdU3-=YAj+xfz6AMLDBpVThH3Xvw@mail.gmail.com>
2012-09-24 14:10 ` Jan Beulich
2012-09-24 14:16 ` Ben Guthro
2012-09-24 14:28 ` Jan Beulich
2012-09-24 19:02 ` Ben Guthro
2012-09-24 20:30 ` Keir Fraser
2012-09-24 20:46 ` Ben Guthro
2012-09-24 21:12 ` Ben Guthro
2012-09-25 7:00 ` Jan Beulich
2012-09-25 11:56 ` Ben Guthro
2012-09-25 14:22 ` Ben Guthro
2012-09-25 14:53 ` Keir Fraser
2012-09-25 15:10 ` Jan Beulich
2012-09-25 15:45 ` Ben Guthro
2012-09-25 15:52 ` Keir Fraser
2012-09-26 11:49 ` Jan Beulich
2012-09-26 10:43 ` Jan Beulich
2012-09-26 10:47 ` Ben Guthro
2012-09-26 18:21 ` Ben Guthro
2012-09-27 7:38 ` Jan Beulich
2012-09-27 7:46 ` Keir Fraser
2012-09-27 12:12 ` Ben Guthro
2012-09-27 13:41 ` Jan Beulich
2012-09-27 15:25 ` Jan Beulich
2012-09-27 15:32 ` Ben Guthro
2012-09-27 15:59 ` [PATCH] x86/ucode: fix Intel case of resume handling on boot CPU Jan Beulich
2012-09-27 16:06 ` Keir Fraser
2012-09-24 14:32 ` Xen4.2 S3 regression? Keir Fraser
2012-09-24 12:22 ` Pasi Kärkkäinen
2012-09-24 12:27 ` Ben Guthro
2012-09-24 12:37 ` Javier Marcet
2012-09-24 14:04 ` Konrad Rzeszutek Wilk
2012-09-24 15:08 ` Javier Marcet
2012-09-24 21:36 ` Javier Marcet
2012-09-25 14:06 ` Konrad Rzeszutek Wilk
2012-09-25 14:47 ` Javier Marcet
2012-09-25 15:21 ` Jan Beulich
2012-09-25 15:23 ` Javier Marcet
2012-09-25 19:55 ` Javier Marcet
2012-09-25 19:57 ` Ben Guthro
2012-09-25 20:08 ` Javier Marcet
2012-09-26 7:17 ` Jan Beulich
2012-09-26 7:59 ` Javier Marcet
2012-09-26 12:43 ` Konrad Rzeszutek Wilk
2012-09-26 14:14 ` Javier Marcet
2012-09-26 14:26 ` Ben Guthro
2012-09-26 14:40 ` Javier Marcet
2012-09-26 8:05 ` Javier Marcet
2012-09-24 12:37 ` Jan Beulich
2012-09-24 14:02 ` Konrad Rzeszutek Wilk
2012-09-20 7:17 ` Jan Beulich
[not found] ` <CAAnFQG-u1VUDgn11ZW0=UaYC4MvUtxxq8ZjjUOrNpXTSUWP41Q@mail.gmail.com>
[not found] ` <CAOvdn6VuD_5Mhd9wvOskfZWfCBjr2nT5LppDxyY5S-5LhGhSvA@mail.gmail.com>
[not found] ` <CAAnFQG_hMNvwM9Z3XPGR590=Gifos-kOftqjLFUX4YFW6tTTgg@mail.gmail.com>
[not found] ` <CAOvdn6UzdzO_sM6f9coN2udQ6eUC5=Sty-NgC7+yf3XMawF-0A@mail.gmail.com>
2012-09-04 15:31 ` Javier Marcet
-- strict thread matches above, loose matches on Subject: below --
2012-08-23 18:54 Andrew Cooper
2012-08-23 19:06 ` Ben Guthro
2012-08-23 19:26 ` Ben Guthro
2012-08-23 19:38 ` Andrew Cooper
2012-08-23 20:38 ` Ben Guthro
2012-08-24 15:10 ` Ben Guthro
2012-08-24 22:16 ` Jan Beulich
[not found] ` <CAOvdn6U1touhawCb2GvgVQZqxhWn9CRw6-wkqdxk=uOTq015OA@mail.gmail.com>
2012-09-06 9:24 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CC81C913.3F4B0%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=JBeulich@suse.com \
--cc=ben@guthro.net \
--cc=john.baboval@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=thomas.goetz@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).