From: Keir Fraser <keir@xen.org>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] x86: slightly improve stack trace on debug builds
Date: Tue, 25 Sep 2012 18:06:51 +0100 [thread overview]
Message-ID: <CC87A33B.4CDD3%keir@xen.org> (raw)
In-Reply-To: <5061F5D7020000780009DC03@nat28.tlf.novell.com>
On 25/09/2012 17:20, "Jan Beulich" <JBeulich@suse.com> wrote:
>> Lol, how does your brain work this way? It took me 15 minutes to decode this
>> to something like (also I added range checks on ESP_BEFORE_EXCEPTION(regs),
>> what do you think?):
>
> Sorry for this - just wanted to avoid having the condition evaluated
> (and spelled out) twice (and it took me a minute at most to find this
> iterate-at-most-twice solution).
It's the kind of code that is definitely easier to write than to read. ;-)
next prev parent reply other threads:[~2012-09-25 17:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-25 15:07 [PATCH] x86: slightly improve stack trace on debug builds Jan Beulich
2012-09-25 15:48 ` Keir Fraser
2012-09-25 16:20 ` Jan Beulich
2012-09-25 17:06 ` Keir Fraser
2012-09-25 17:06 ` Keir Fraser [this message]
2012-09-26 7:04 ` [PATCH, v2] " Jan Beulich
2012-09-26 7:54 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CC87A33B.4CDD3%keir@xen.org \
--to=keir@xen.org \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).