From: Keir Fraser <keir.xen@gmail.com>
To: "Hao, Xudong" <xudong.hao@intel.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Cc: "Zhang, Xiantao" <xiantao.zhang@intel.com>,
"ian.campbell@citrix.com" <ian.campbell@citrix.com>,
"jbeulich@suse.com" <jbeulich@suse.com>,
Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
Subject: Re: [PATCH v2] xen/tools: Add 64 bits big bar support
Date: Wed, 26 Sep 2012 07:25:29 +0100 [thread overview]
Message-ID: <CC885E69.3FF58%keir.xen@gmail.com> (raw)
In-Reply-To: <403610A45A2B5242BD291EDAE8B37D300FEC702B@SHSMSX102.ccr.corp.intel.com>
On 26/09/2012 01:58, "Hao, Xudong" <xudong.hao@intel.com> wrote:
>>> @@ -258,8 +298,8 @@
>>> resource->base = base;
>>>
>>> pci_writel(devfn, bar_reg, bar_data);
>>> - printf("pci dev %02x:%x bar %02x size %08x: %08x\n",
>>> - devfn>>3, devfn&7, bar_reg, bar_sz, bar_data);
>>> + if (using_64bar)
>>> + pci_writel(devfn, bar_reg + 4, bar_data_upper);
>>
>> Why is the printf removed?
>>
>
> No special reason. It's a successful print, I'll modify patch if we want to
> remain it.
Yes please.
prev parent reply other threads:[~2012-09-26 6:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-25 3:33 [PATCH v2] xen/tools: Add 64 bits big bar support Unknown
2012-09-25 8:31 ` Ian Campbell
2012-09-25 9:14 ` Hao, Xudong
2012-09-25 9:25 ` Ian Campbell
2012-09-25 14:13 ` Keir Fraser
2012-09-26 0:58 ` Hao, Xudong
2012-09-26 6:25 ` Keir Fraser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CC885E69.3FF58%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=jbeulich@suse.com \
--cc=xen-devel@lists.xen.org \
--cc=xiantao.zhang@intel.com \
--cc=xudong.hao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).