From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.xen@gmail.com>
Subject: Re: [PATCH v2] xen/tools: Add 64 bits big bar support
Date: Wed, 26 Sep 2012 07:25:29 +0100
Message-ID: <CC885E69.3FF58%keir.xen@gmail.com>
References: <403610A45A2B5242BD291EDAE8B37D300FEC702B@SHSMSX102.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <403610A45A2B5242BD291EDAE8B37D300FEC702B@SHSMSX102.ccr.corp.intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "Hao, Xudong" <xudong.hao@intel.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Cc: "Zhang, Xiantao" <xiantao.zhang@intel.com>, "ian.campbell@citrix.com" <ian.campbell@citrix.com>, "jbeulich@suse.com" <jbeulich@suse.com>, Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 26/09/2012 01:58, "Hao, Xudong" <xudong.hao@intel.com> wrote:

>>> @@ -258,8 +298,8 @@
>>>          resource->base = base;
>>> 
>>>          pci_writel(devfn, bar_reg, bar_data);
>>> -        printf("pci dev %02x:%x bar %02x size %08x: %08x\n",
>>> -               devfn>>3, devfn&7, bar_reg, bar_sz, bar_data);
>>> +        if (using_64bar)
>>> +            pci_writel(devfn, bar_reg + 4, bar_data_upper);
>> 
>> Why is the printf removed?
>> 
> 
> No special reason. It's a successful print, I'll modify patch if we want to
> remain it.

Yes please.