From: Keir Fraser <keir@xen.org>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH, v2] x86: slightly improve stack trace on debug builds
Date: Wed, 26 Sep 2012 08:54:13 +0100 [thread overview]
Message-ID: <CC887335.4CE74%keir@xen.org> (raw)
In-Reply-To: <5062C50B020000780009DE1C@nat28.tlf.novell.com>
On 26/09/2012 08:04, "Jan Beulich" <JBeulich@suse.com> wrote:
> As was rather obvious from crashes recently happening in stage testing,
> the debug hypervisor, in that special case, has a drawback compared to
> the non-debug one: When a call through a bad pointer happens, there's
> no frame, and the top level (and frequently most important for
> analysis) stack entry would get skipped:
>
...
>
> Since the bad pointer is being printed anyway (as part of the register
> state), replace it with the top of stack value in such a case.
>
> With the introduction of is_active_kernel_text(), use it also at the
> (few) other suitable places (I intentionally didn't replace the use in
> xen/arch/arm/mm.c - while it would be functionally correct, the
> dependency on system_state wouldn't be from an abstract perspective).
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Keir Fraser <keir@xen.org>
prev parent reply other threads:[~2012-09-26 7:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-25 15:07 [PATCH] x86: slightly improve stack trace on debug builds Jan Beulich
2012-09-25 15:48 ` Keir Fraser
2012-09-25 16:20 ` Jan Beulich
2012-09-25 17:06 ` Keir Fraser
2012-09-25 17:06 ` Keir Fraser
2012-09-26 7:04 ` [PATCH, v2] " Jan Beulich
2012-09-26 7:54 ` Keir Fraser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CC887335.4CE74%keir@xen.org \
--to=keir@xen.org \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).