From: Keir Fraser <keir.xen@gmail.com>
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xen.org>
Cc: Jinsong Liu <jinsong.liu@intel.com>
Subject: Re: [PATCH] fix inclusion style in public/domctl.h
Date: Thu, 04 Oct 2012 15:31:46 +0100 [thread overview]
Message-ID: <CC935C62.40D5A%keir.xen@gmail.com> (raw)
In-Reply-To: <506DB10A020000780009FA9F@nat28.tlf.novell.com>
On 04/10/2012 14:53, "Jan Beulich" <JBeulich@suse.com> wrote:
> Public headers should include one another only via self-relative
> include directives (violated by 25955:07d0d5b3a005).
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Keir Fraser <keir@xen.org>
> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -32,9 +32,9 @@
> #error "domctl operations are intended for use by node control tools only"
> #endif
>
> -#include <xen/hvm/save.h>
> #include "xen.h"
> #include "grant_table.h"
> +#include "hvm/save.h"
>
> #define XEN_DOMCTL_INTERFACE_VERSION 0x00000008
>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
prev parent reply other threads:[~2012-10-04 14:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-04 13:53 [PATCH] fix inclusion style in public/domctl.h Jan Beulich
2012-10-04 14:31 ` Keir Fraser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CC935C62.40D5A%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=JBeulich@suse.com \
--cc=jinsong.liu@intel.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).