* [PATCH] fix inclusion style in public/domctl.h
@ 2012-10-04 13:53 Jan Beulich
2012-10-04 14:31 ` Keir Fraser
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2012-10-04 13:53 UTC (permalink / raw)
To: xen-devel; +Cc: Jinsong Liu
[-- Attachment #1: Type: text/plain, Size: 510 bytes --]
Public headers should include one another only via self-relative
include directives (violated by 25955:07d0d5b3a005).
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -32,9 +32,9 @@
#error "domctl operations are intended for use by node control tools only"
#endif
-#include <xen/hvm/save.h>
#include "xen.h"
#include "grant_table.h"
+#include "hvm/save.h"
#define XEN_DOMCTL_INTERFACE_VERSION 0x00000008
[-- Attachment #2: domctl-include-hvm-save.patch --]
[-- Type: text/plain, Size: 546 bytes --]
fix inclusion style in public/domctl.h
Public headers should include one another only via self-relative
include directives (violated by 25955:07d0d5b3a005).
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -32,9 +32,9 @@
#error "domctl operations are intended for use by node control tools only"
#endif
-#include <xen/hvm/save.h>
#include "xen.h"
#include "grant_table.h"
+#include "hvm/save.h"
#define XEN_DOMCTL_INTERFACE_VERSION 0x00000008
[-- Attachment #3: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] fix inclusion style in public/domctl.h
2012-10-04 13:53 [PATCH] fix inclusion style in public/domctl.h Jan Beulich
@ 2012-10-04 14:31 ` Keir Fraser
0 siblings, 0 replies; 2+ messages in thread
From: Keir Fraser @ 2012-10-04 14:31 UTC (permalink / raw)
To: Jan Beulich, xen-devel; +Cc: Jinsong Liu
On 04/10/2012 14:53, "Jan Beulich" <JBeulich@suse.com> wrote:
> Public headers should include one another only via self-relative
> include directives (violated by 25955:07d0d5b3a005).
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Keir Fraser <keir@xen.org>
> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -32,9 +32,9 @@
> #error "domctl operations are intended for use by node control tools only"
> #endif
>
> -#include <xen/hvm/save.h>
> #include "xen.h"
> #include "grant_table.h"
> +#include "hvm/save.h"
>
> #define XEN_DOMCTL_INTERFACE_VERSION 0x00000008
>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-04 14:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-04 13:53 [PATCH] fix inclusion style in public/domctl.h Jan Beulich
2012-10-04 14:31 ` Keir Fraser
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).