From: Keir Fraser <keir@xen.org>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH 3/3] x86/HPET: cache MSI message last written
Date: Fri, 19 Oct 2012 10:32:56 +0100 [thread overview]
Message-ID: <CCA6DCD8.50130%keir@xen.org> (raw)
In-Reply-To: <5081241402000078000A2837@nat28.tlf.novell.com>
On 19/10/2012 08:57, "Jan Beulich" <JBeulich@suse.com> wrote:
>>> That wouldn't be correct: The function _is_ unused (and there's
>>> no issue if it was used afaik), and the __used__ attribute ought
>>> to tell the compiler to keep the function around despite not
>>> having (visible to it) callers.
>>
>> Perhaps our __attribute_used__ definition should change, then?
>
> I don't think so - this has its own value as is. We may want to add
> a Linux-like __maybe_unused, though.
Could you do that, and add comments to the definitions of __attribute_used__
and __maybe_unused, describing exactly what they are to be used for?
Thanks,
Keir
next prev parent reply other threads:[~2012-10-19 9:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-16 15:05 [PATCH 0/3] x86: HPET adjustments Jan Beulich
2012-10-16 15:09 ` [PATCH 1/3] x86/HPET: obtain proper lock for changing IRQ affinity Jan Beulich
2012-10-16 15:41 ` Keir Fraser
2012-10-16 16:11 ` Jan Beulich
2012-10-16 21:49 ` Keir Fraser
2012-10-17 11:45 ` [PATCH v2 " Jan Beulich
2012-10-17 11:58 ` Keir Fraser
2012-10-16 15:10 ` [PATCH 2/3] x86/HPET: allow use for broadcast when interrupt remapping is in effect Jan Beulich
2012-10-17 11:47 ` [PATCH v2 " Jan Beulich
2012-10-17 11:59 ` Keir Fraser
2012-10-18 0:31 ` Zhang, Xiantao
2012-10-18 8:11 ` Jan Beulich
2012-10-16 15:11 ` [PATCH 3/3] x86/HPET: cache MSI message last written Jan Beulich
2012-10-18 8:22 ` Keir Fraser
2012-10-18 10:39 ` Jan Beulich
2012-10-18 16:42 ` Keir Fraser
2012-10-19 7:57 ` Jan Beulich
2012-10-19 9:32 ` Keir Fraser [this message]
2012-10-19 9:40 ` Jan Beulich
2012-10-25 11:53 ` [PATCH v2] " Jan Beulich
2012-10-25 12:18 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CCA6DCD8.50130%keir@xen.org \
--to=keir@xen.org \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).