From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.xen@gmail.com>
Subject: Re: [PATCH 1/2,
 v2] x86: use MOV instead of PUSH/POP when saving/restoring register
 state
Date: Tue, 30 Oct 2012 15:36:01 +0100
Message-ID: <CCB5A461.42C7B%keir.xen@gmail.com>
References: <508FF012.30901@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <508FF012.30901@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Mats Petersson <mats.petersson@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 30/10/2012 16:19, "Mats Petersson" <mats.petersson@citrix.com> wrote:

>>   #ifdef CONFIG_FRAME_POINTER
>>   /* Indicate special exception stack frame by inverting the frame pointer.
>> */
>> -#define SETUP_EXCEPTION_FRAME_POINTER           \
>> -        movq  %rsp,%rbp;                        \
>> +#define SETUP_EXCEPTION_FRAME_POINTER(offs)     \
>> +        leaq  offs(%rsp),%rbp;                  \
>>           notq  %rbp
>>   #else
>> -#define SETUP_EXCEPTION_FRAME_POINTER
>> +#define SETUP_EXCEPTION_FRAME_POINTER(off)
> Is it too pedantic to say that "off" here should be "offs"?
> Just for consistency...

No, it's a fair point. :)