From: Keir Fraser <keir@xen.org>
To: Tim Deegan <tim@xen.org>, Ian Campbell <Ian.Campbell@citrix.com>
Cc: Malcolm Crossley <malcolm.crossley@citrix.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"eddie.dong@intel.com" <eddie.dong@intel.com>,
"JBeulich@suse.com" <JBeulich@suse.com>,
"Nakajima, Jun" <jun.nakajima@intel.com>
Subject: Re: [PATCH] xen: vmx: Use an INT 2 call to process real NMI's instead of self_nmi() in VMEXIT handler
Date: Tue, 13 Nov 2012 14:28:48 +0000 [thread overview]
Message-ID: <CCC809A0.520FE%keir@xen.org> (raw)
In-Reply-To: <20121113133953.GF44675@ocelot.phlegethon.org>
On 13/11/2012 13:39, "Tim Deegan" <tim@xen.org> wrote:
>>> diff -r 62885b3c34c8 -r e1fbee58b25c xen/arch/x86/hvm/vmx/vmx.c
>>> --- a/xen/arch/x86/hvm/vmx/vmx.c
>>> +++ b/xen/arch/x86/hvm/vmx/vmx.c
>>> @@ -2442,7 +2442,7 @@ void vmx_vmexit_handler(struct cpu_user_
>>> (X86_EVENTTYPE_NMI << 8) )
>>> goto exit_and_crash;
>>> HVMTRACE_0D(NMI);
>>> - self_nmi(); /* Real NMI, vector 2: normal processing. */
>>> + asm("int $2"); /* Real NMI, vector 2: normal processing. */
>>
>> asm volatile("...")
>>
>> I think? Otherwise this could potentially get hoisted up
>
> Good catch. Hoisted would be fine, but it could also be entirely
> discarded. :)
Parameter-less asm blocks are a special case that will never be considered
side-effect free I believe. Still 'asm volatile' would be our stylistic
choice in this case anyway.
And with that:
Acked-by: Keir Fraser <keir@xen.org>
prev parent reply other threads:[~2012-11-13 14:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-13 13:21 [PATCH] xen: vmx: Use an INT 2 call to process real NMI's instead of self_nmi() in VMEXIT handler Malcolm Crossley
2012-11-13 13:29 ` Ian Campbell
2012-11-13 13:39 ` Tim Deegan
2012-11-13 14:16 ` Jan Beulich
2012-11-13 14:28 ` Keir Fraser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CCC809A0.520FE%keir@xen.org \
--to=keir@xen.org \
--cc=Ian.Campbell@citrix.com \
--cc=JBeulich@suse.com \
--cc=eddie.dong@intel.com \
--cc=jun.nakajima@intel.com \
--cc=malcolm.crossley@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).