From: Keir Fraser <keir.xen@gmail.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Wei Huang <wei.huang2@amd.com>,
xen-devel <xen-devel@lists.xen.org>,
Wei Wang <weiwang.dd@gmail.com>,
xiantao.zhang@intel.com, Gang Wei <gang.wei@intel.com>
Subject: Re: [PATCH 5/5] VT-d: adjust IOMMU interrupt affinities when all CPUs are online
Date: Wed, 21 Nov 2012 11:29:57 +0000 [thread overview]
Message-ID: <CCD26BB5.451A9%keir.xen@gmail.com> (raw)
In-Reply-To: <50ACC67002000078000AA56A@nat28.tlf.novell.com>
On 21/11/2012 11:17, "Jan Beulich" <JBeulich@suse.com> wrote:
>> Is this just a handy place to hook?
>
> Yes.
>
>> Does it logically make sense?
>
> No. Just needed to put it somewhere where it would get run at
> the right point in time, and the place here ensures this for both
> boot and resume.
Yuk! And it doesn't work anyway. acpi_dmar_zap() isn't usually called during
boot -- go see it open coded at the end of acpi_parse_dmar(). It's only
called during boot when running tboot.
> Shall I add a comment to this effect?
I would rather have this added as another call to
acpi/power.c:enter_state(). It doesn't logically belong with
acpi_dmar_zap(), nor even with all its callers (e.g.,
tboot_parse_dmar_table).
-- Keir
next prev parent reply other threads:[~2012-11-21 11:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 10:06 [PATCH 0/5] HPET and IOMMU adjustments Jan Beulich
2012-11-21 10:16 ` [PATCH 1/5] x86/HPET: include FSB interrupt information in 'M' debug key output Jan Beulich
2012-11-21 10:17 ` [PATCH 2/5] VT-d: include IOMMU " Jan Beulich
2012-11-21 10:18 ` [PATCH 3/5] AMD IOMMU: " Jan Beulich
2012-11-21 10:19 ` [PATCH 4/5] x86/HPET: fix FSB interrupt masking Jan Beulich
2012-11-21 10:19 ` [PATCH 5/5] VT-d: adjust IOMMU interrupt affinities when all CPUs are online Jan Beulich
2012-11-21 11:10 ` Keir Fraser
2012-11-21 11:17 ` Jan Beulich
2012-11-21 11:29 ` Keir Fraser [this message]
2012-11-21 11:58 ` Jan Beulich
2012-11-21 12:13 ` [PATCH 5/5 v2] " Jan Beulich
2012-11-21 12:45 ` Keir Fraser
2012-11-21 11:11 ` [PATCH 0/5] HPET and IOMMU adjustments Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CCD26BB5.451A9%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=JBeulich@suse.com \
--cc=gang.wei@intel.com \
--cc=wei.huang2@amd.com \
--cc=weiwang.dd@gmail.com \
--cc=xen-devel@lists.xen.org \
--cc=xiantao.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).