From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.xen@gmail.com>
Subject: Re: [PATCH 5/5] VT-d: adjust IOMMU interrupt affinities
 when all CPUs are online
Date: Wed, 21 Nov 2012 11:29:57 +0000
Message-ID: <CCD26BB5.451A9%keir.xen@gmail.com>
References: <50ACC67002000078000AA56A@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <50ACC67002000078000AA56A@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Wei Huang <wei.huang2@amd.com>, xen-devel <xen-devel@lists.xen.org>, Wei Wang <weiwang.dd@gmail.com>, xiantao.zhang@intel.com, Gang Wei <gang.wei@intel.com>
List-Id: xen-devel@lists.xenproject.org

On 21/11/2012 11:17, "Jan Beulich" <JBeulich@suse.com> wrote:

>> Is this just a handy place to hook?
> 
> Yes.
> 
>> Does it logically make sense?
> 
> No. Just needed to put it somewhere where it would get run at
> the right point in time, and the place here ensures this for both
> boot and resume.

Yuk! And it doesn't work anyway. acpi_dmar_zap() isn't usually called during
boot -- go see it open coded at the end of acpi_parse_dmar(). It's only
called during boot when running tboot.

> Shall I add a comment to this effect?

I would rather have this added as another call to
acpi/power.c:enter_state(). It doesn't logically belong with
acpi_dmar_zap(), nor even with all its callers (e.g.,
tboot_parse_dmar_table).

 -- Keir