From: Keir Fraser <keir@xen.org>
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] IOMMU: imply "verbose" from "debug"
Date: Wed, 28 Nov 2012 15:50:51 +0000 [thread overview]
Message-ID: <CCDBE35B.53A8D%keir@xen.org> (raw)
In-Reply-To: <50B62EAE02000078000AC2B7@nat28.tlf.novell.com>
On 28/11/2012 14:33, "Jan Beulich" <JBeulich@suse.com> wrote:
> I think that generally enabling debugging code without also enabling
> verbose output is rather pointless; if someone really wants this, they
> can always pass e.g. "iommu=debug,no-verbose".
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Keir Fraser <keir@xen.org>
> --- a/xen/drivers/passthrough/iommu.c
> +++ b/xen/drivers/passthrough/iommu.c
> @@ -92,7 +92,11 @@ static void __init parse_iommu_param(cha
> else if ( !strcmp(s, "intremap") )
> iommu_intremap = val;
> else if ( !strcmp(s, "debug") )
> + {
> iommu_debug = val;
> + if ( val )
> + iommu_verbose = 1;
> + }
> else if ( !strcmp(s, "amd-iommu-perdev-intremap") )
> amd_iommu_perdev_intremap = val;
> else if ( !strcmp(s, "dom0-passthrough") )
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
prev parent reply other threads:[~2012-11-28 15:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-28 14:33 [PATCH] IOMMU: imply "verbose" from "debug" Jan Beulich
2012-11-28 15:50 ` Keir Fraser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CCDBE35B.53A8D%keir@xen.org \
--to=keir@xen.org \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).