From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir@xen.org>
Subject: Re: [PATCH] IOMMU: imply "verbose" from "debug"
Date: Wed, 28 Nov 2012 15:50:51 +0000
Message-ID: <CCDBE35B.53A8D%keir@xen.org>
References: <50B62EAE02000078000AC2B7@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <50B62EAE02000078000AC2B7@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 28/11/2012 14:33, "Jan Beulich" <JBeulich@suse.com> wrote:

> I think that generally enabling debugging code without also enabling
> verbose output is rather pointless; if someone really wants this, they
> can always pass e.g. "iommu=debug,no-verbose".
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Keir Fraser <keir@xen.org>

> --- a/xen/drivers/passthrough/iommu.c
> +++ b/xen/drivers/passthrough/iommu.c
> @@ -92,7 +92,11 @@ static void __init parse_iommu_param(cha
>          else if ( !strcmp(s, "intremap") )
>              iommu_intremap = val;
>          else if ( !strcmp(s, "debug") )
> +        {
>              iommu_debug = val;
> +            if ( val )
> +                iommu_verbose = 1;
> +        }
>          else if ( !strcmp(s, "amd-iommu-perdev-intremap") )
>              amd_iommu_perdev_intremap = val;
>          else if ( !strcmp(s, "dom0-passthrough") )
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel