From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir@xen.org>
Subject: Re: [PATCH] AMD IOMMU: add locking missing from c/s
 26198:ba90ecb0231f
Date: Fri, 30 Nov 2012 11:14:57 +0000
Message-ID: <CCDE45B1.54678%keir@xen.org>
References: <50B8762102000078000ACBC6@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <50B8762102000078000ACBC6@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xen.org>
Cc: Wei Huang <wei.huang2@amd.com>, Wei Wang <weiwang.dd@gmail.com>
List-Id: xen-devel@lists.xenproject.org

On 30/11/2012 08:02, "Jan Beulich" <JBeulich@suse.com> wrote:

> An oversight of mine; I'm sorry.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Keir Fraser <keir@xen.org>

> --- a/xen/drivers/passthrough/amd/iommu_init.c
> +++ b/xen/drivers/passthrough/amd/iommu_init.c
> @@ -795,6 +795,7 @@ static bool_t __init set_iommu_interrupt
>  static void enable_iommu(struct amd_iommu *iommu)
>  {
>      unsigned long flags;
> +    struct irq_desc *desc;
>  
>      spin_lock_irqsave(&iommu->lock, flags);
>  
> @@ -812,7 +813,11 @@ static void enable_iommu(struct amd_iomm
>      if ( iommu_has_feature(iommu, IOMMU_EXT_FEATURE_PPRSUP_SHIFT) )
>          register_iommu_ppr_log_in_mmio_space(iommu);
>  
> -    set_msi_affinity(irq_to_desc(iommu->msi.irq), &cpu_online_map);
> +    desc = irq_to_desc(iommu->msi.irq);
> +    spin_lock(&desc->lock);
> +    set_msi_affinity(desc, &cpu_online_map);
> +    spin_unlock(&desc->lock);
> +
>      amd_iommu_msi_enable(iommu, IOMMU_CONTROL_ENABLED);
>  
>      set_iommu_ht_flags(iommu);
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel