xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Keir Fraser <keir@xen.org>
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] x86/HVM: remove dead code
Date: Thu, 06 Dec 2012 13:04:59 +0000	[thread overview]
Message-ID: <CCE6487B.550B5%keir@xen.org> (raw)
In-Reply-To: <50C0A3C302000078000AE896@nat28.tlf.novell.com>

On 06/12/2012 12:55, "Jan Beulich" <JBeulich@suse.com> wrote:

> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Keir Fraser <keir@xen.org>

> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -2460,9 +2460,7 @@ static enum hvm_copy_result __hvm_copy(
>              return HVMCOPY_unhandleable;
>          }
>          if ( !page )
> -        {
>              return HVMCOPY_bad_gfn_to_mfn;
> -        }
>  
>          p = (char *)__map_domain_page(page) + (addr & ~PAGE_MASK);
>  
> @@ -2560,11 +2558,7 @@ static enum hvm_copy_result __hvm_clear(
>              return HVMCOPY_unhandleable;
>          }
>          if ( !page )
> -        {
> -            if ( page )
> -                put_page(page);
>              return HVMCOPY_bad_gfn_to_mfn;
> -        }
>  
>          p = (char *)__map_domain_page(page) + (addr & ~PAGE_MASK);
>  
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel

  reply	other threads:[~2012-12-06 13:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-06 12:55 [PATCH] x86/HVM: remove dead code Jan Beulich
2012-12-06 13:04 ` Keir Fraser [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-04-04  6:28 Jan Beulich
2016-04-05  9:34 ` Andrew Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CCE6487B.550B5%keir@xen.org \
    --to=keir@xen.org \
    --cc=JBeulich@suse.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).