From: Keir Fraser <keir@xen.org>
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] x86/p2m: drop redundant macro definitions
Date: Thu, 06 Dec 2012 15:55:02 +0000 [thread overview]
Message-ID: <CCE67056.551CE%keir@xen.org> (raw)
In-Reply-To: <50C0A4DA02000078000AE8BF@nat28.tlf.novell.com>
On 06/12/2012 12:59, "Jan Beulich" <JBeulich@suse.com> wrote:
> Also, add log level indicator to P2M_ERROR(), and drop pointless
> underscores from all related macros' parameter names.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Keir Fraser <keir@xen.org>
> --- a/xen/arch/x86/mm/p2m.c
> +++ b/xen/arch/x86/mm/p2m.c
> @@ -46,18 +46,6 @@ boolean_param("hap_1gb", opt_hap_1gb);
> bool_t __read_mostly opt_hap_2mb = 1;
> boolean_param("hap_2mb", opt_hap_2mb);
>
> -/* Printouts */
> -#define P2M_PRINTK(_f, _a...) \
> - debugtrace_printk("p2m: %s(): " _f, __func__, ##_a)
> -#define P2M_ERROR(_f, _a...) \
> - printk("pg error: %s(): " _f, __func__, ##_a)
> -#if P2M_DEBUGGING
> -#define P2M_DEBUG(_f, _a...) \
> - debugtrace_printk("p2mdebug: %s(): " _f, __func__, ##_a)
> -#else
> -#define P2M_DEBUG(_f, _a...) do { (void)(_f); } while(0)
> -#endif
> -
>
> /* Override macros from asm/page.h to make them work with mfn_t */
> #undef mfn_to_page
> --- a/xen/include/asm-x86/p2m.h
> +++ b/xen/include/asm-x86/p2m.h
> @@ -607,15 +607,15 @@ extern void audit_p2m(struct domain *d,
> #endif /* P2M_AUDIT */
>
> /* Printouts */
> -#define P2M_PRINTK(_f, _a...) \
> - debugtrace_printk("p2m: %s(): " _f, __func__, ##_a)
> -#define P2M_ERROR(_f, _a...) \
> - printk("pg error: %s(): " _f, __func__, ##_a)
> +#define P2M_PRINTK(f, a...) \
> + debugtrace_printk("p2m: %s(): " f, __func__, ##a)
> +#define P2M_ERROR(f, a...) \
> + printk(XENLOG_G_ERR "pg error: %s(): " f, __func__, ##a)
> #if P2M_DEBUGGING
> -#define P2M_DEBUG(_f, _a...) \
> - debugtrace_printk("p2mdebug: %s(): " _f, __func__, ##_a)
> +#define P2M_DEBUG(f, a...) \
> + debugtrace_printk("p2mdebug: %s(): " f, __func__, ##a)
> #else
> -#define P2M_DEBUG(_f, _a...) do { (void)(_f); } while(0)
> +#define P2M_DEBUG(f, a...) do { (void)(f); } while(0)
> #endif
>
> /* Called by p2m code when demand-populating a PoD page */
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
prev parent reply other threads:[~2012-12-06 15:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-06 12:59 [PATCH] x86/p2m: drop redundant macro definitions Jan Beulich
2012-12-06 15:55 ` Keir Fraser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CCE67056.551CE%keir@xen.org \
--to=keir@xen.org \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).