From: Keir Fraser <keir@xen.org>
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] x86: properly fail mmuext ops when get_page_from_gfn() fails
Date: Thu, 06 Dec 2012 15:55:18 +0000 [thread overview]
Message-ID: <CCE67066.551CF%keir@xen.org> (raw)
In-Reply-To: <50C0A4B302000078000AE8BB@nat28.tlf.novell.com>
On 06/12/2012 12:59, "Jan Beulich" <JBeulich@suse.com> wrote:
> I noticed this inconsistency while analyzing the code for XSA-32.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Keir Fraser <keir@xen.org>
> --- a/xen/arch/x86/mm.c
> +++ b/xen/arch/x86/mm.c
> @@ -2776,7 +2776,7 @@ long do_mmuext_op(
> page = get_page_from_gfn(pg_owner, op.arg1.mfn, NULL, P2M_ALLOC);
> if ( unlikely(!page) )
> {
> - rc = -EINVAL;
> + okay = 0;
> break;
> }
>
> @@ -2836,6 +2836,7 @@ long do_mmuext_op(
> page = get_page_from_gfn(pg_owner, op.arg1.mfn, NULL, P2M_ALLOC);
> if ( unlikely(!page) )
> {
> + okay = 0;
> MEM_LOG("Mfn %lx bad domain", op.arg1.mfn);
> break;
> }
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
prev parent reply other threads:[~2012-12-06 15:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-06 12:59 [PATCH] x86: properly fail mmuext ops when get_page_from_gfn() fails Jan Beulich
2012-12-06 15:55 ` Keir Fraser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CCE67066.551CF%keir@xen.org \
--to=keir@xen.org \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).