* [PATCH] x86/HVM: add missing assert to stdvga's mmio_move()
@ 2012-12-06 12:56 Jan Beulich
2012-12-06 15:55 ` Keir Fraser
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2012-12-06 12:56 UTC (permalink / raw)
To: xen-devel
[-- Attachment #1: Type: text/plain, Size: 496 bytes --]
... to match the IOREQ_READ path.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/hvm/stdvga.c
+++ b/xen/arch/x86/hvm/stdvga.c
@@ -519,6 +519,7 @@ static int mmio_move(struct hvm_hw_stdvg
put_page(dp);
return 0;
}
+ ASSERT(!dp);
tmp = stdvga_mem_read(data, p->size);
}
stdvga_mem_write(addr, tmp, p->size);
[-- Attachment #2: x86-hvm-stdvga-missing-assert.patch --]
[-- Type: text/plain, Size: 545 bytes --]
x86/HVM: add missing assert to stdvga's mmio_move()
... to match the IOREQ_READ path.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/hvm/stdvga.c
+++ b/xen/arch/x86/hvm/stdvga.c
@@ -519,6 +519,7 @@ static int mmio_move(struct hvm_hw_stdvg
put_page(dp);
return 0;
}
+ ASSERT(!dp);
tmp = stdvga_mem_read(data, p->size);
}
stdvga_mem_write(addr, tmp, p->size);
[-- Attachment #3: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] x86/HVM: add missing assert to stdvga's mmio_move()
2012-12-06 12:56 [PATCH] x86/HVM: add missing assert to stdvga's mmio_move() Jan Beulich
@ 2012-12-06 15:55 ` Keir Fraser
0 siblings, 0 replies; 2+ messages in thread
From: Keir Fraser @ 2012-12-06 15:55 UTC (permalink / raw)
To: Jan Beulich, xen-devel
On 06/12/2012 12:56, "Jan Beulich" <JBeulich@suse.com> wrote:
> ... to match the IOREQ_READ path.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Keir Fraser <keir@xen.org>
> --- a/xen/arch/x86/hvm/stdvga.c
> +++ b/xen/arch/x86/hvm/stdvga.c
> @@ -519,6 +519,7 @@ static int mmio_move(struct hvm_hw_stdvg
> put_page(dp);
> return 0;
> }
> + ASSERT(!dp);
> tmp = stdvga_mem_read(data, p->size);
> }
> stdvga_mem_write(addr, tmp, p->size);
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-12-06 15:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-06 12:56 [PATCH] x86/HVM: add missing assert to stdvga's mmio_move() Jan Beulich
2012-12-06 15:55 ` Keir Fraser
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).