* [PATCH] x86: also print CRn register values upon double fault
@ 2012-12-19 13:03 Jan Beulich
2012-12-19 13:22 ` Keir Fraser
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2012-12-19 13:03 UTC (permalink / raw)
To: xen-devel
[-- Attachment #1: Type: text/plain, Size: 1859 bytes --]
Do so by simply re-using _show_registers().
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/x86_64/traps.c
+++ b/xen/arch/x86/x86_64/traps.c
@@ -225,6 +225,7 @@ void double_fault(void);
void do_double_fault(struct cpu_user_regs *regs)
{
unsigned int cpu;
+ unsigned long crs[8];
watchdog_disable();
@@ -235,22 +236,18 @@ void do_double_fault(struct cpu_user_reg
/* Find information saved during fault and dump it to the console. */
printk("*** DOUBLE FAULT ***\n");
print_xen_info();
- printk("CPU: %d\nRIP: %04x:[<%016lx>]",
- cpu, regs->cs, regs->rip);
- print_symbol(" %s", regs->rip);
- printk("\nRFLAGS: %016lx\n", regs->rflags);
- printk("rax: %016lx rbx: %016lx rcx: %016lx\n",
- regs->rax, regs->rbx, regs->rcx);
- printk("rdx: %016lx rsi: %016lx rdi: %016lx\n",
- regs->rdx, regs->rsi, regs->rdi);
- printk("rbp: %016lx rsp: %016lx r8: %016lx\n",
- regs->rbp, regs->rsp, regs->r8);
- printk("r9: %016lx r10: %016lx r11: %016lx\n",
- regs->r9, regs->r10, regs->r11);
- printk("r12: %016lx r13: %016lx r14: %016lx\n",
- regs->r12, regs->r13, regs->r14);
- printk("r15: %016lx cs: %016lx ss: %016lx\n",
- regs->r15, (long)regs->cs, (long)regs->ss);
+
+ crs[0] = read_cr0();
+ crs[2] = read_cr2();
+ crs[3] = read_cr3();
+ crs[4] = read_cr4();
+ regs->ds = read_segment_register(ds);
+ regs->es = read_segment_register(es);
+ regs->fs = read_segment_register(fs);
+ regs->gs = read_segment_register(gs);
+
+ printk("CPU: %d\n", cpu);
+ _show_registers(regs, crs, CTXT_hypervisor, NULL);
show_stack_overflow(cpu, regs->rsp);
panic("DOUBLE FAULT -- system shutdown\n");
[-- Attachment #2: x86-double-fault-print-CRs.patch --]
[-- Type: text/plain, Size: 1910 bytes --]
x86: also print CRn register values upon double fault
Do so by simply re-using _show_registers().
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/x86_64/traps.c
+++ b/xen/arch/x86/x86_64/traps.c
@@ -225,6 +225,7 @@ void double_fault(void);
void do_double_fault(struct cpu_user_regs *regs)
{
unsigned int cpu;
+ unsigned long crs[8];
watchdog_disable();
@@ -235,22 +236,18 @@ void do_double_fault(struct cpu_user_reg
/* Find information saved during fault and dump it to the console. */
printk("*** DOUBLE FAULT ***\n");
print_xen_info();
- printk("CPU: %d\nRIP: %04x:[<%016lx>]",
- cpu, regs->cs, regs->rip);
- print_symbol(" %s", regs->rip);
- printk("\nRFLAGS: %016lx\n", regs->rflags);
- printk("rax: %016lx rbx: %016lx rcx: %016lx\n",
- regs->rax, regs->rbx, regs->rcx);
- printk("rdx: %016lx rsi: %016lx rdi: %016lx\n",
- regs->rdx, regs->rsi, regs->rdi);
- printk("rbp: %016lx rsp: %016lx r8: %016lx\n",
- regs->rbp, regs->rsp, regs->r8);
- printk("r9: %016lx r10: %016lx r11: %016lx\n",
- regs->r9, regs->r10, regs->r11);
- printk("r12: %016lx r13: %016lx r14: %016lx\n",
- regs->r12, regs->r13, regs->r14);
- printk("r15: %016lx cs: %016lx ss: %016lx\n",
- regs->r15, (long)regs->cs, (long)regs->ss);
+
+ crs[0] = read_cr0();
+ crs[2] = read_cr2();
+ crs[3] = read_cr3();
+ crs[4] = read_cr4();
+ regs->ds = read_segment_register(ds);
+ regs->es = read_segment_register(es);
+ regs->fs = read_segment_register(fs);
+ regs->gs = read_segment_register(gs);
+
+ printk("CPU: %d\n", cpu);
+ _show_registers(regs, crs, CTXT_hypervisor, NULL);
show_stack_overflow(cpu, regs->rsp);
panic("DOUBLE FAULT -- system shutdown\n");
[-- Attachment #3: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] x86: also print CRn register values upon double fault
2012-12-19 13:03 [PATCH] x86: also print CRn register values upon double fault Jan Beulich
@ 2012-12-19 13:22 ` Keir Fraser
0 siblings, 0 replies; 2+ messages in thread
From: Keir Fraser @ 2012-12-19 13:22 UTC (permalink / raw)
To: Jan Beulich, xen-devel
On 19/12/2012 13:03, "Jan Beulich" <JBeulich@suse.com> wrote:
> Do so by simply re-using _show_registers().
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Keir Fraser <keir@xen.org>
> --- a/xen/arch/x86/x86_64/traps.c
> +++ b/xen/arch/x86/x86_64/traps.c
> @@ -225,6 +225,7 @@ void double_fault(void);
> void do_double_fault(struct cpu_user_regs *regs)
> {
> unsigned int cpu;
> + unsigned long crs[8];
>
> watchdog_disable();
>
> @@ -235,22 +236,18 @@ void do_double_fault(struct cpu_user_reg
> /* Find information saved during fault and dump it to the console. */
> printk("*** DOUBLE FAULT ***\n");
> print_xen_info();
> - printk("CPU: %d\nRIP: %04x:[<%016lx>]",
> - cpu, regs->cs, regs->rip);
> - print_symbol(" %s", regs->rip);
> - printk("\nRFLAGS: %016lx\n", regs->rflags);
> - printk("rax: %016lx rbx: %016lx rcx: %016lx\n",
> - regs->rax, regs->rbx, regs->rcx);
> - printk("rdx: %016lx rsi: %016lx rdi: %016lx\n",
> - regs->rdx, regs->rsi, regs->rdi);
> - printk("rbp: %016lx rsp: %016lx r8: %016lx\n",
> - regs->rbp, regs->rsp, regs->r8);
> - printk("r9: %016lx r10: %016lx r11: %016lx\n",
> - regs->r9, regs->r10, regs->r11);
> - printk("r12: %016lx r13: %016lx r14: %016lx\n",
> - regs->r12, regs->r13, regs->r14);
> - printk("r15: %016lx cs: %016lx ss: %016lx\n",
> - regs->r15, (long)regs->cs, (long)regs->ss);
> +
> + crs[0] = read_cr0();
> + crs[2] = read_cr2();
> + crs[3] = read_cr3();
> + crs[4] = read_cr4();
> + regs->ds = read_segment_register(ds);
> + regs->es = read_segment_register(es);
> + regs->fs = read_segment_register(fs);
> + regs->gs = read_segment_register(gs);
> +
> + printk("CPU: %d\n", cpu);
> + _show_registers(regs, crs, CTXT_hypervisor, NULL);
> show_stack_overflow(cpu, regs->rsp);
>
> panic("DOUBLE FAULT -- system shutdown\n");
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-12-19 13:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-19 13:03 [PATCH] x86: also print CRn register values upon double fault Jan Beulich
2012-12-19 13:22 ` Keir Fraser
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).