From: Keir Fraser <keir.xen@gmail.com>
To: Ian Campbell <Ian.Campbell@citrix.com>, Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xen.org>
Subject: Re: Ping: [PATCH] x86: compat_show_guest_stack() should not truncate MFN
Date: Mon, 07 Jan 2013 12:22:02 +0000 [thread overview]
Message-ID: <CD106E6A.48688%keir.xen@gmail.com> (raw)
In-Reply-To: <1357560463.7989.44.camel@zakaz.uk.xensource.com>
On 07/01/2013 12:07, "Ian Campbell" <Ian.Campbell@citrix.com> wrote:
> On Mon, 2013-01-07 at 12:00 +0000, Jan Beulich wrote:
>>>>> On 20.12.12 at 17:54, Jan Beulich wrote:
>>> Re-using "addr" here was a mistake, as it is a 32-bit quantity.
>>>
>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> Looks right to me
>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
Yes, I must have missed this patch first time round.
Acked-by: Keir Fraser <keir@xen.org>
>>>
>>> --- a/xen/arch/x86/x86_64/compat/traps.c
>>> +++ b/xen/arch/x86/x86_64/compat/traps.c
>>> @@ -20,11 +20,12 @@ void compat_show_guest_stack(struct vcpu
>>> if ( v != current )
>>> {
>>> struct vcpu *vcpu;
>>> + unsigned long mfn;
>>>
>>> ASSERT(guest_kernel_mode(v, regs));
>>> - addr = read_cr3() >> PAGE_SHIFT;
>>> + mfn = read_cr3() >> PAGE_SHIFT;
>>> for_each_vcpu( v->domain, vcpu )
>>> - if ( pagetable_get_pfn(vcpu->arch.guest_table) == addr )
>>> + if ( pagetable_get_pfn(vcpu->arch.guest_table) == mfn )
>>> break;
>>> if ( !vcpu )
>>> {
>>>
>>>
>>>
>>
>>
>>
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xen.org
>> http://lists.xen.org/xen-devel
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
prev parent reply other threads:[~2013-01-07 12:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-07 12:00 Ping: [PATCH] x86: compat_show_guest_stack() should not truncate MFN Jan Beulich
2013-01-07 12:07 ` Ian Campbell
2013-01-07 12:22 ` Keir Fraser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CD106E6A.48688%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=Ian.Campbell@citrix.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).