From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.xen@gmail.com>
Subject: Re: Ping: [PATCH] x86: compat_show_guest_stack() should
 not truncate MFN
Date: Mon, 07 Jan 2013 12:22:02 +0000
Message-ID: <CD106E6A.48688%keir.xen@gmail.com>
References: <1357560463.7989.44.camel@zakaz.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1357560463.7989.44.camel@zakaz.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>, Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 07/01/2013 12:07, "Ian Campbell" <Ian.Campbell@citrix.com> wrote:

> On Mon, 2013-01-07 at 12:00 +0000, Jan Beulich wrote:
>>>>> On 20.12.12 at 17:54, Jan Beulich wrote:
>>> Re-using "addr" here was a mistake, as it is a 32-bit quantity.
>>> 
>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> Looks right to me
> 
> Acked-by: Ian Campbell <ian.campbell@citrix.com>

Yes, I must have missed this patch first time round.

Acked-by: Keir Fraser <keir@xen.org>

>>> 
>>> --- a/xen/arch/x86/x86_64/compat/traps.c
>>> +++ b/xen/arch/x86/x86_64/compat/traps.c
>>> @@ -20,11 +20,12 @@ void compat_show_guest_stack(struct vcpu
>>>      if ( v != current )
>>>      {
>>>          struct vcpu *vcpu;
>>> +        unsigned long mfn;
>>>  
>>>          ASSERT(guest_kernel_mode(v, regs));
>>> -        addr = read_cr3() >> PAGE_SHIFT;
>>> +        mfn = read_cr3() >> PAGE_SHIFT;
>>>          for_each_vcpu( v->domain, vcpu )
>>> -            if ( pagetable_get_pfn(vcpu->arch.guest_table) == addr )
>>> +            if ( pagetable_get_pfn(vcpu->arch.guest_table) == mfn )
>>>                  break;
>>>          if ( !vcpu )
>>>          {
>>> 
>>> 
>>> 
>> 
>> 
>> 
>> 
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xen.org
>> http://lists.xen.org/xen-devel
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel