* Ping: [PATCH] x86: compat_show_guest_stack() should not truncate MFN
@ 2013-01-07 12:00 Jan Beulich
2013-01-07 12:07 ` Ian Campbell
0 siblings, 1 reply; 3+ messages in thread
From: Jan Beulich @ 2013-01-07 12:00 UTC (permalink / raw)
To: xen-devel
>>> On 20.12.12 at 17:54, Jan Beulich wrote:
> Re-using "addr" here was a mistake, as it is a 32-bit quantity.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> --- a/xen/arch/x86/x86_64/compat/traps.c
> +++ b/xen/arch/x86/x86_64/compat/traps.c
> @@ -20,11 +20,12 @@ void compat_show_guest_stack(struct vcpu
> if ( v != current )
> {
> struct vcpu *vcpu;
> + unsigned long mfn;
>
> ASSERT(guest_kernel_mode(v, regs));
> - addr = read_cr3() >> PAGE_SHIFT;
> + mfn = read_cr3() >> PAGE_SHIFT;
> for_each_vcpu( v->domain, vcpu )
> - if ( pagetable_get_pfn(vcpu->arch.guest_table) == addr )
> + if ( pagetable_get_pfn(vcpu->arch.guest_table) == mfn )
> break;
> if ( !vcpu )
> {
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: Ping: [PATCH] x86: compat_show_guest_stack() should not truncate MFN
2013-01-07 12:00 Ping: [PATCH] x86: compat_show_guest_stack() should not truncate MFN Jan Beulich
@ 2013-01-07 12:07 ` Ian Campbell
2013-01-07 12:22 ` Keir Fraser
0 siblings, 1 reply; 3+ messages in thread
From: Ian Campbell @ 2013-01-07 12:07 UTC (permalink / raw)
To: Jan Beulich; +Cc: xen-devel
On Mon, 2013-01-07 at 12:00 +0000, Jan Beulich wrote:
> >>> On 20.12.12 at 17:54, Jan Beulich wrote:
> > Re-using "addr" here was a mistake, as it is a 32-bit quantity.
> >
> > Signed-off-by: Jan Beulich <jbeulich@suse.com>
Looks right to me
Acked-by: Ian Campbell <ian.campbell@citrix.com>
> >
> > --- a/xen/arch/x86/x86_64/compat/traps.c
> > +++ b/xen/arch/x86/x86_64/compat/traps.c
> > @@ -20,11 +20,12 @@ void compat_show_guest_stack(struct vcpu
> > if ( v != current )
> > {
> > struct vcpu *vcpu;
> > + unsigned long mfn;
> >
> > ASSERT(guest_kernel_mode(v, regs));
> > - addr = read_cr3() >> PAGE_SHIFT;
> > + mfn = read_cr3() >> PAGE_SHIFT;
> > for_each_vcpu( v->domain, vcpu )
> > - if ( pagetable_get_pfn(vcpu->arch.guest_table) == addr )
> > + if ( pagetable_get_pfn(vcpu->arch.guest_table) == mfn )
> > break;
> > if ( !vcpu )
> > {
> >
> >
> >
>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: Ping: [PATCH] x86: compat_show_guest_stack() should not truncate MFN
2013-01-07 12:07 ` Ian Campbell
@ 2013-01-07 12:22 ` Keir Fraser
0 siblings, 0 replies; 3+ messages in thread
From: Keir Fraser @ 2013-01-07 12:22 UTC (permalink / raw)
To: Ian Campbell, Jan Beulich; +Cc: xen-devel
On 07/01/2013 12:07, "Ian Campbell" <Ian.Campbell@citrix.com> wrote:
> On Mon, 2013-01-07 at 12:00 +0000, Jan Beulich wrote:
>>>>> On 20.12.12 at 17:54, Jan Beulich wrote:
>>> Re-using "addr" here was a mistake, as it is a 32-bit quantity.
>>>
>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> Looks right to me
>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
Yes, I must have missed this patch first time round.
Acked-by: Keir Fraser <keir@xen.org>
>>>
>>> --- a/xen/arch/x86/x86_64/compat/traps.c
>>> +++ b/xen/arch/x86/x86_64/compat/traps.c
>>> @@ -20,11 +20,12 @@ void compat_show_guest_stack(struct vcpu
>>> if ( v != current )
>>> {
>>> struct vcpu *vcpu;
>>> + unsigned long mfn;
>>>
>>> ASSERT(guest_kernel_mode(v, regs));
>>> - addr = read_cr3() >> PAGE_SHIFT;
>>> + mfn = read_cr3() >> PAGE_SHIFT;
>>> for_each_vcpu( v->domain, vcpu )
>>> - if ( pagetable_get_pfn(vcpu->arch.guest_table) == addr )
>>> + if ( pagetable_get_pfn(vcpu->arch.guest_table) == mfn )
>>> break;
>>> if ( !vcpu )
>>> {
>>>
>>>
>>>
>>
>>
>>
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xen.org
>> http://lists.xen.org/xen-devel
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-07 12:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-07 12:00 Ping: [PATCH] x86: compat_show_guest_stack() should not truncate MFN Jan Beulich
2013-01-07 12:07 ` Ian Campbell
2013-01-07 12:22 ` Keir Fraser
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).