From: Keir Fraser <keir@xen.org>
To: Daniel De Graaf <dgdegra@tycho.nsa.gov>,
Ian Campbell <Ian.Campbell@citrix.com>
Cc: Jan Beulich <jbeulich@suse.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH] arch/x86/hvm: Bind xen-created event channels to building domain
Date: Wed, 09 Jan 2013 15:02:30 +0000 [thread overview]
Message-ID: <CD133706.57ED1%keir@xen.org> (raw)
In-Reply-To: <50ED8206.2090006@tycho.nsa.gov>
On 09/01/2013 14:43, "Daniel De Graaf" <dgdegra@tycho.nsa.gov> wrote:
>> OOI what is the builder (I assume it's not specific to being a separate
>> domain) doing that requires it to access to the IOEMU event channels?
>>
>> Ian.
>>
>
> I believe this caused problems when the device model was running in the
> same domain as the domain builder (where that was not dom0), not during
> the domain build process. After seeing Keir and Jan's comments, I think
> the best solution is for the domain builder to set HVM_PARAM_DM_DOMAIN
> to DOMID_SELF (or the actual device model domain ID) earlier in the
> build process and use that parameter in the event channel creation
> instead of 0 or current->domain->domain_id.
This is the fix I have just applied as xen-unstable:26339. See what you
think. It will require you to set HVM_PARAM_DM_DOMAIN from the toolstack at
some point during domain creation, any time before the device model starts
running.
-- Keir
prev parent reply other threads:[~2013-01-09 15:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-03 18:28 [PATCH] arch/x86/hvm: Bind xen-created event channels to building domain Daniel De Graaf
2013-01-09 8:51 ` Keir Fraser
2013-01-09 10:27 ` Jan Beulich
2013-01-09 11:12 ` Ian Campbell
2013-01-09 14:43 ` Daniel De Graaf
2013-01-09 14:56 ` Ian Campbell
2013-01-09 15:30 ` Daniel De Graaf
2013-01-09 15:38 ` Keir Fraser
2013-01-09 16:24 ` Ian Campbell
2013-01-09 15:02 ` Keir Fraser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CD133706.57ED1%keir@xen.org \
--to=keir@xen.org \
--cc=Ian.Campbell@citrix.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=jbeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).